Closed Bug 917826 Opened 11 years ago Closed 11 years ago

[Clock] Use Full Line Highlights

Categories

(Firefox OS Graveyard :: Gaia::Clock, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Clock
Platform:
All
Other
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:-)

Status:
RESOLVED FIXED
Project Flags:
blocking-b2g -

People

(Reporter: epang, Assigned: pivanov)

References

Details

(Whiteboard: visual design, visual-tracking, jian)

Attachments

(3 files, 3 obsolete files)

Clock.jpg
29.74 KB, image/jpeg
Details
After patch screenshot (desktop)
29.30 KB, image/png
epang
: feedback+
Details
patch for Gaia/master
183 bytes, text/html
sjochimek
: review+
Details
1. Use full width highlights (edge to edge) for active/pressed states 2. Update highlight color to #348c9e
Attached image Clock.jpg —
Attached image After patch screenshot (obsolete) —
Attachment #808293 - Flags: feedback?(epang)
Attached file patch for Gaia/master (obsolete) —
(In reply to Pavel Ivanov [:ivanovpavel] from comment #2) > Created attachment 808293 [details] > After patch screenshot Hi Pavel, something looks off with the highlight color/opacity. Can you check if these are the settings being used? thx! #348c9e 60% Opacity
Flags: needinfo?(pivanov)
Oh, I use only #348c9e without opacity I will change it. Thanks :)
Flags: needinfo?(pivanov)
Attachment #808293 - Attachment is obsolete: true
Attachment #808293 - Flags: feedback?(epang)
Attachment #808995 - Flags: feedback?(epang)
Comment on attachment 808995 [details] After patch screenshot (desktop) This looks good now, thanks Pavel!
Attachment #808995 - Flags: feedback?(epang) → feedback+
Attachment #808294 - Flags: review?(sjochimek)
Comment on attachment 808294 [details] patch for Gaia/master Landed in master: https://github.com/mozilla-b2g/gaia/commit/43e12b5b31916790280ef77cd3248c5802d8a810
Attachment #808294 - Flags: review?(sjochimek) → review+
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Reverted on suspicion of causing bug 923092: https://github.com/mozilla-b2g/gaia/commit/51f218a74ca4c3c21c2acddff1cf59355aba59de
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(In reply to Ed Morley [:edmorley UTC+1] from comment #9) > Reverted on suspicion of causing bug 923092: > https://github.com/mozilla-b2g/gaia/commit/ > 51f218a74ca4c3c21c2acddff1cf59355aba59de Hey Pavel, can you look into this?
Flags: needinfo?(pivanov)
I have a patch for this ... it's just a z-index problem ... I will update the bug latter today ... just need to test one more thing ...
Flags: needinfo?(pivanov)
Attachment #808294 - Attachment is obsolete: true
Attached file patch for Gaia/master —
Hey Sam, I fixed the z-index issue ... now it works :)
Attachment #814747 - Flags: review?(sjochimek)
Attachment #815363 - Attachment is obsolete: true
(In reply to Pavel Ivanov [:ivanovpavel] from comment #13) > Created attachment 814747 [details] > patch for Gaia/master > > Hey Sam, > I fixed the z-index issue ... now it works :) Sam, can you review so we can land this? thanks!
Flags: needinfo?(sjochimek)
Comment on attachment 814747 [details] patch for Gaia/master Landed in master: https://github.com/mozilla-b2g/gaia/commit/6026f44da9c75dfdce06232e0df6b65cf91c9d06
Attachment #814747 - Flags: review?(sjochimek) → review+
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Flags: needinfo?(sjochimek)
Resolution: --- → FIXED
Whiteboard: visual design, visual-tracking → visual design, visual-tracking, jian
I'm requesting "koi+" because this is a CSS-only change that enhances usability by making alarms easier to interact with.
blocking-b2g: --- → koi?
blocking-b2g: koi? → -
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: