917840 - [Music] Use Full Line Highlights

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::Music, defect)

Description

[Eric Pang [:epang] UX]

Attachment: Music List - Margin for Index.jpg

Highlight extends to the edge on the left.  On the right there is a 30px margin to allow for the scroll index.

Comment 1

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Hey Eric, 
I think that ... we don't have the A/B etc. scroll implemented on music ... or maybe I need to do something to see the scroll?

Comment 2

[Eric Pang [:epang] UX]

(In reply to Pavel Ivanov [:ivanovpavel] from comment #1)
> Hey Eric, 
> I think that ... we don't have the A/B etc. scroll implemented on music ...
> or maybe I need to do something to see the scroll?

I noticed that to, I think it still should be there.. Will try to find out what's going on. thx

Comment 3

[Eric Pang [:epang] UX]

Flagging as 1.3? since the highlight state currently looks broken.

Comment 4

[Hema Koka [:hema]]

Cosmetic, not marking this blocker for 1.3

Comment 5

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Hey Eric,
is there any news about this?

Comment 6

[Eric Pang [:epang] UX]

(In reply to Pavel Ivanov [:ivanovpavel] from comment #5)
> Hey Eric,
> is there any news about this?

I believe the scroll index should be there, so the highlight should be the way it is in my mock up (ending at the album art).  Is this possible? Thanks!

Comment 7

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

I think so ... but I remember that we talk with someone about this? or maybe I mess the talks ... but it's not so easy to add the a/b/c scroll here ... it's part from the app

Comment 8

[Eric Pang [:epang] UX]

(In reply to Pavel Ivanov [:ivanovpavel] from comment #7)
> I think so ... but I remember that we talk with someone about this? or maybe
> I mess the talks ... but it's not so easy to add the a/b/c scroll here ...
> it's part from the app

Hey Jacqueline, Pavel noticed a while back that the search index was no longer showing up in the music app (on the artist, album and songs tabs).  Should these be added in or do you know if they were they intentionally removed? Thanks!

Comment 9

[Jacqueline Savory [:jsavory] UX]

I'm not aware of any reason why the search index was removed, as far as I know it should be there. We are planning a redesign of music and in this redesign, the search index will be included.

Comment 10

[Eric Pang [:epang] UX]

(In reply to jsavory from comment #9)
> I'm not aware of any reason why the search index was removed, as far as I
> know it should be there. We are planning a redesign of music and in this
> redesign, the search index will be included.

Thanks Jacqueline!

Hey Pavel, so it seems like we can add it back in and continue with the implementation of the highlight when you have time.  Thanks!