[System] Use Full Line Highlights in value selectors

RESOLVED FIXED

Status

Firefox OS
Gaia::System
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: epang, Assigned: ivanovpavel)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: visual design, visual-tracking, jian)

Attachments

(3 attachments)

(Reporter)

Description

5 years ago
Created attachment 806682 [details]
Value Selectors.jpg

Use full width highlights (edge to edge) for active/pressed states
Hey Eric,

I have a question ... What I need to do on active state?
1. I need to hide the top and bottom border?
2. hide only the top one?
3. hide only the bottom one?
4. or something else ... because it's hard to make the behavior on you screenshot 

Thanks in advance :) I'm sure that you have the right answer for me :)
Flags: needinfo?(epang)
Created attachment 807782 [details]
After patch screenshot (desktop)
Created attachment 807784 [details]
patch for Gaia/master
Attachment #807784 - Flags: review?(sjochimek)
Attachment #807782 - Flags: feedback?(epang)
(Reporter)

Comment 4

5 years ago
Comment on attachment 807782 [details]
After patch screenshot (desktop)

tested the PR, looks good!  Thanks Pavel :)
Attachment #807782 - Flags: feedback?(epang) → feedback+

Comment 5

5 years ago
Comment on attachment 807784 [details]
patch for Gaia/master

Landed in master: https://github.com/mozilla-b2g/gaia/commit/1223e35e76a1bb36cc5d52372474020bdf97d2c1
Attachment #807784 - Flags: review?(sjochimek) → review+

Comment 6

5 years ago
Nice one by the way :)
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Reporter)

Updated

5 years ago
Flags: needinfo?(epang)
(Reporter)

Updated

5 years ago
Whiteboard: visual design, visual-tracking → visual design, visual-tracking, jian
You need to log in before you can comment on or make changes to this bug.