Closed Bug 917857 Opened 6 years ago Closed 6 years ago

[System] Use Full Line Highlights in value selectors

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System
Platform:
All
Other
Type:
defect
Priority:
Not set

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: epang, Assigned: pivanov)

References

Details

(Whiteboard: visual design, visual-tracking, jian)

Attachments

(3 files)

Value Selectors.jpg
40.84 KB, image/jpeg
Details
After patch screenshot (desktop)
73.80 KB, image/png
epang
: feedback+
Details
patch for Gaia/master
183 bytes, text/html
sjochimek
: review+
Details
Attached image Value Selectors.jpg — 
Use full width highlights (edge to edge) for active/pressed states
Hey Eric,

I have a question ... What I need to do on active state?
1. I need to hide the top and bottom border?
2. hide only the top one?
3. hide only the bottom one?
4. or something else ... because it's hard to make the behavior on you screenshot 

Thanks in advance :) I'm sure that you have the right answer for me :)
Flags: needinfo?(epang)
Attached file patch for Gaia/master —
Attachment #807784 - Flags: review?(sjochimek)
Attachment #807782 - Flags: feedback?(epang)
Comment on attachment 807782 [details]
After patch screenshot (desktop)

tested the PR, looks good!  Thanks Pavel :)
Attachment #807782 - Flags: feedback?(epang) → feedback+
Comment on attachment 807784 [details]
patch for Gaia/master

Landed in master: https://github.com/mozilla-b2g/gaia/commit/1223e35e76a1bb36cc5d52372474020bdf97d2c1
Attachment #807784 - Flags: review?(sjochimek) → review+
Nice one by the way :)
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Flags: needinfo?(epang)
Whiteboard: visual design, visual-tracking → visual design, visual-tracking, jian
You need to log in before you can comment on or make changes to this bug.