Closed
Bug 917857
Opened 12 years ago
Closed 12 years ago
[System] Use Full Line Highlights in value selectors
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: epang, Assigned: pivanov)
References
Details
(Whiteboard: visual design, visual-tracking, jian)
Attachments
(3 files)
Value Selectors.jpg
Use full width highlights (edge to edge) for active/pressed states
|
Assignee | |
Comment 1•12 years ago
|
||
Hey Eric,
I have a question ... What I need to do on active state?
1. I need to hide the top and bottom border?
2. hide only the top one?
3. hide only the bottom one?
4. or something else ... because it's hard to make the behavior on you screenshot
Thanks in advance :) I'm sure that you have the right answer for me :)
Flags: needinfo?(epang)
|
|
Assignee | |
Comment 2•12 years ago
|
||
|
|
Assignee | |
Comment 3•12 years ago
|
||
Attachment #807784 -
Flags: review?(sjochimek)
|
|
Assignee | |
Updated•12 years ago
|
Attachment #807782 -
Flags: feedback?(epang)
|
Reporter | |
Comment 4•12 years ago
|
||
Comment on attachment 807782 [details]
After patch screenshot (desktop)
tested the PR, looks good! Thanks Pavel :)
Attachment #807782 -
Flags: feedback?(epang) → feedback+
|
||
Comment 5•12 years ago
|
||
Comment on attachment 807784 [details]
patch for Gaia/master
Landed in master: https://github.com/mozilla-b2g/gaia/commit/1223e35e76a1bb36cc5d52372474020bdf97d2c1
Attachment #807784 -
Flags: review?(sjochimek) → review+
|
|
||
Comment 6•12 years ago
|
||
Nice one by the way :)
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Updated•12 years ago
|
Flags: needinfo?(epang)
|
|
Reporter | |
Updated•12 years ago
|
Whiteboard: visual design, visual-tracking → visual design, visual-tracking, jian
You need to log in
before you can comment on or make changes to this bug.
Description
•