917863 - Add XUL context menu back into rule and computed views

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

The menu is to contain:
 - Select All
 - Copy

As simple as it gets.

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: xul-context-menu-917863.patch

Comment 2

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Try:
https://tbpl.mozilla.org/?tree=Try&rev=bd3b6beaf1e5

Comment 3

[Joe Walker [:jwalker] (needinfo me or ping on irc)]

Comment on attachment 806687 [details] [diff] [review]
xul-context-menu-917863.patch

Review of attachment 806687 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/styleinspector/computed-view.js
@@ +484,5 @@
> +  _buildContextMenu: function()
> +  {
> +    let doc = this.styleDocument.defaultView.parent.document;
> +
> +    let menu = this._contextmenu = this.styleDocument.createElementNS(XUL_NS, "menupopup");

Does this aliasing (menu/this._contextmenu) help readability significantly? I think there is a risk of confusing people with aliasing so we should only do it when there is a clear win.

@@ +527,5 @@
> +   */
> +  _onContextMenu: function(event) {
> +    try {
> +      let win = this.styleDocument.defaultView;
> +      win.focus();

Do we need the 'win' variable?

@@ +531,5 @@
> +      win.focus();
> +
> +      this._contextmenu.openPopup(
> +        event.target.ownerDocument.documentElement,
> +        "overlap", event.clientX, event.clientY, true, false, null);

Uber-nit: Could you use 4 space indents for continuation lines? A continuation line is very different from block indent, and particularly with if statements, using the same indent can be confusing.

Comment 4

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Fixed leak

Fixed leak:
https://tbpl.mozilla.org/?tree=Try&rev=629343b39cda

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/59d5404eadf5

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/59d5404eadf5