Closed Bug 917878 Opened 8 years ago Closed 7 years ago

"patches submitted" and "patches reviewed" on the user profile don't take github pull requests into consideration

Categories

(bugzilla.mozilla.org :: Extensions, defect)

Production
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: glob, Assigned: dkl)

References

Details

Attachments

(1 file)

some teams use github to track their development, but use bugzilla to track their reviews.  their process involves attaching a github pr url, and requesting a review on that.

because these attachments aren't tagged as patches, they are not counted by the user profile :(


one way of fixing this is to add a new column to attachments - is_github (or similar) and automatically set that to true when the attachment is created.  the user profile can then search for (ispatch = 1 OR is_github = 1).  that would also help the redirect when viewing (bug 916906).
Duplicate of this bug: 927444
we need to look for a content-type of text/x-github-pull-request
Attached patch 917878_1.patchSplinter Review
Assignee: nobody → dkl
Status: NEW → ASSIGNED
Attachment #8372637 - Flags: review?(glob)
Comment on attachment 8372637 [details] [diff] [review]
917878_1.patch

nice, r=glob

once this has been pushed we'll have to run the following SQL to trigger a recalculation of existing statistics:

UPDATE profiles SET last_statistics_ts = NULL WHERE userid IN (SELECT submitter_id FROM attachments WHERE mimetype = 'text/x-github-pull-request');
Attachment #8372637 - Flags: review?(glob) → review+
Committing to: bzr+ssh://dlawrence%40mozilla.com@bzr.mozilla.org/bmo/4.2
modified extensions/UserProfile/lib/Util.pm
Committed revision 9225. 

glob, please have ashish (or whomever does the push) run the SQL then afterwards.

dkl
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Any chance you all can also capture this pull-request.html (text/html) pattern? I see it a lot in Firefox OS, like https://bugzilla.mozilla.org/show_bug.cgi?id=922609
(In reply to Asa Dotzler [:asa] from comment #6)
> Any chance you all can also capture this pull-request.html (text/html)
> pattern? I see it a lot in Firefox OS, like
> https://bugzilla.mozilla.org/show_bug.cgi?id=922609

as that request is very different from this bug, i've filed as bug 970195.
(In reply to David Lawrence [:dkl] from comment #5)
> Committing to: bzr+ssh://dlawrence%40mozilla.com@bzr.mozilla.org/bmo/4.2
> modified extensions/UserProfile/lib/Util.pm
> Committed revision 9225. 
> 
> glob, please have ashish (or whomever does the push) run the SQL then
> afterwards.
> 
> dkl

SQL ran successfully on the master:

> mysql> UPDATE profiles SET last_statistics_ts = NULL WHERE userid IN (SELECT submitter_id FROM attachments WHERE mimetype = 'text/x-github-pull-request');
> Query OK, 307 rows affected, 1 warning (6.89 sec)
> Rows matched: 333  Changed: 307  Warnings: 1
Component: Extensions: UserProfile → Extensions
You need to log in before you can comment on or make changes to this bug.