Fix color-burn and color-dodge blend modes for Direct2D

RESOLVED FIXED in mozilla27

Status

()

Core
Graphics
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: Rik Cabanier, Assigned: Rik Cabanier)

Tracking

Trunk
mozilla27
x86_64
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

5 years ago
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/29.0.1547.66 Safari/537.36

Steps to reproduce:

Run reftests for SVG blending on the d2d backend


Actual results:

Failure for d2d


Expected results:

D2D should match Cairo, Skia and Core Graphics
(Assignee)

Updated

5 years ago
Component: Untriaged → Graphics
Product: Firefox → Core
(Assignee)

Comment 1

5 years ago
Created attachment 806774 [details] [diff] [review]
Updated .fx file + recompiled effects + enabled reftest
(Assignee)

Comment 2

5 years ago
Created attachment 806903 [details] [diff] [review]
Updated .fx file + recompiled effects + enabled reftest
Attachment #806774 - Attachment is obsolete: true
(Assignee)

Updated

5 years ago
Attachment #806774 - Flags: review?(bas)
(Assignee)

Comment 3

5 years ago
try server build: https://tbpl.mozilla.org/?tree=Try&rev=2ab2ab0481e1
(Assignee)

Updated

5 years ago
Attachment #806903 - Flags: review?(bas)
Attachment #806903 - Flags: review?(bas) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
Attachment #806774 - Flags: review?(bas)
https://hg.mozilla.org/integration/mozilla-inbound/rev/1b66f13a5c5a

As requested previously, please make sure that you have Hg configured to include your name in your patches to make landing easier for others.
Assignee: nobody → cabanier
Keywords: checkin-needed
(Assignee)

Comment 5

5 years ago
Created attachment 807368 [details] [diff] [review]
Updated .fx file + recompiled effects + enabled reftest
Attachment #806903 - Attachment is obsolete: true
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
Thanks for the effort, but it already landed on inbound in comment 4 :)
Keywords: checkin-needed

Comment 7

5 years ago
https://hg.mozilla.org/mozilla-central/rev/1b66f13a5c5a
Status: UNCONFIRMED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
(Assignee)

Updated

4 years ago
Blocks: 952643
You need to log in before you can comment on or make changes to this bug.