917956 - [Clock] Timer spinner allows for out-of-bound input

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Clock, defect)

Description

[Mike Pennisi [:jugglinmike]]

Steps to reproduce:

1. Navigate to the "Timer" panel
2. Use the "spinner" UI element to specify a duration of 59 seconds
3. Attempt to drag the spinner upwards by one more unit

Expected: the spinner does not move

Actual: the spinner "rolls over" to an empty value

Comment 1

[Corey Frang [:gnarf]]

Attachment: patch v1

Simple range calculation error fixed.  Values can go from [0, values.length-1] not from [0, values.length]

Comment 2

[Mike Pennisi [:jugglinmike]]

Comment on attachment 806870 [details] [diff] [review]
patch v1

Review of attachment 806870 [details] [diff] [review]:
-----------------------------------------------------------------

Nicely done, Corey.

Comment 3

[Corey Frang [:gnarf]]

master: https://github.com/mozilla-b2g/gaia/commit/8a4a02484fadf275a43c112153b88eb7b1538862

Comment 4

[Mike Pennisi [:jugglinmike]]

Requesting "koi+" because invalid input should not be allowed.

Comment 5

[Dylan Oliver [:doliver]]

triage: koi+, low-risk

Comment 6

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 8a4a02484fadf275a43c112153b88eb7b1538862 to:
v1.2: e679bea2a5725a942353b970dace18c30129d6ca

Comment 7

[Chris Kreinbring [:CKreinbring]]

Verified on Buri 1.2 mozilla RIL.  Attempting to scroll the timer rollers past their limit will cause the rollers to snap back to the maximum value (23 for hour, 59 for minute and second) once they're released.

Build ID: 20130925004005
Gecko: http://hg.mozilla.org/releases/mozilla-aurora/rev/fb764e648a8f
Gaia: b0e4a1333bb7bf0a749a384ba99e4f03f111e39a
Platform Version: 26.0a2