917965 - UA overrides are disabled if update is invalid

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

If an update is invalid (i.e. request succeeds but the content is invalid), the UA override list will be set to null, effectively disabling overrides. We should keep the old list instead.

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Don't apply or save invalid updates (v1)

Prevent null UA override list

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Noming for 1.2 too.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/f9bc1da07766

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f9bc1da07766

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/a59d0e8196a0

Comment 6

[Ioana (away)]

Is there any way I can simulate invalid updates in order to reproduce/verify this bug?

Comment 7

[(inactive) Jim Chen [:jchen] [:darchons]]

(In reply to Ioana Budnar, QA [:ioana] from comment #6)
> Is there any way I can simulate invalid updates in order to reproduce/verify
> this bug?

It's a bit complicated. With the latest build of B2G, 

1) Verify r7.com in the browser displays the mobile site and not the desktop site
2) Set the pref "general.useragent.updates.url" to "http://people.mozilla.org/~nchen/ua/ua-invalid.json"
3) Set the pref "general.useragent.updates.interval" to 60
4) Wait 5 minutes for the update to occur
5) Verify r7.com still displays the mobile site and not the desktop site

Comment 8

[Ioana (away)]

Thanks for the steps but, unfortunately, I don't have access to B2G devices. Does this bug also affect Firefox for desktop somehow?

Comment 9

[(inactive) Jim Chen [:jchen] [:darchons]]

(In reply to Ioana Budnar, QA [:ioana] from comment #8)
> Thanks for the steps but, unfortunately, I don't have access to B2G devices.
> Does this bug also affect Firefox for desktop somehow?

Unfortunately the code only runs on B2G. Maybe a B2G QA can verify this.

Comment 10

[Bogdan Maris, Desktop Test Engineering]

Dropping verifyme because the flag was added for Firefox Desktop.