Closed Bug 917970 Opened 10 years ago Closed 9 years ago

Large text on door-hanger for mixed content blocking on high DPI devices

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Version:
27 Branch
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox27 wontfix, firefox28 wontfix, firefox29 wontfix, firefox30 wontfix, firefox31 wontfix, firefox32 wontfix, firefox33 verified, firefox34 verified, fennec+)

Status:
VERIFIED FIXED
Milestone:
Firefox 34
Tracking Flags:
Tracking Status
firefox27 --- wontfix
firefox28 --- wontfix
firefox29 --- wontfix
firefox30 --- wontfix
firefox31 --- wontfix
firefox32 --- wontfix
firefox33 --- verified
firefox34 --- verified
fennec + ---

People

(Reporter: aaronmt, Assigned: Margaret, Mentored)

References

Details

(Keywords: reproducible, Whiteboard: [lang=java])

Attachments

(2 files, 2 obsolete files)

screenshot.png
150.66 KB, image/png
Details
Use correct text size for mixed content blocking notification
4.97 KB, patch
lucasr
: review+
Sylvestre
: approval-mozilla-aurora+
Details | Diff | Splinter Review
Attached image device-2013-09-18-142608.png (obsolete) — 
See screenshot. DPI issue?

Steps to Reproduce

i) http://fhr.cdn.mozilla.net/en-US/mobile/?v=1#raw
ii) Tap the protection shield

--
Samsung Galaxy S4 (Android 4.3)
Nightly (09/18)
Is this actually a regression? It was probably caused by me doing something dumb in my patch for bug 885962. It does look like a DPI issue, I don't think I've ever tested on a screen with as high resolution as the S4.
Blocks: 885962
Yeah looks correct on the Nexus 4.
Keywords: regression, regressionwindow-wanted
Summary: Regression: Jumbo doorhanger text → Large text on door-hanger for mixed content blocking on high DPI devices
tracking-fennec: ? → +
This would be a good bug for someone familiar with Android UI. Like I mentioned in comment 1, we're likely just doing something wrong with how we're setting the text size.
Whiteboard: [lang=java][mentor=margaret]
Attached image caution door-hanger screenshot (obsolete) — 
There's also the caution door-hanger screenshot which is ridiculously big.
Mentor: margaret.leibovic
Whiteboard: [lang=java][mentor=margaret] → [lang=java]
Attached image screenshot.png — 
Still comically large (08/13).
Attachment #806806 - Attachment is obsolete: true
Attachment #8369300 - Attachment is obsolete: true
status-firefox25: ? → ---
status-firefox26: ? → ---
Margaret - Time to just do it?
Flags: needinfo?(margaret.leibovic)
(In reply to Mark Finkle (:mfinkle) from comment #7)
> Margaret - Time to just do it?

Sure, I can look into making a patch.
Assignee: nobody → margaret.leibovic
Flags: needinfo?(margaret.leibovic)
This patch uses styles instead of manually trying to change the text size. Aaron verified that this fixes the problem.
Attachment #8472530 - Flags: review?(lucasr.at.mozilla)
Comment on attachment 8472530 [details] [diff] [review]
Use correct text size for mixed content blocking notification

Review of attachment 8472530 [details] [diff] [review]:
-----------------------------------------------------------------

?android:attr/textAppearanceMedium is not resolving correctly it seems.
Attachment #8472530 - Flags: review?(lucasr.at.mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/d53b311f9e35
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
Status: RESOLVED → VERIFIED
status-firefox34: affected → verified
Flags: qe-verify+
Comment on attachment 8472530 [details] [diff] [review]
Use correct text size for mixed content blocking notification

Approval Request Comment
[Feature/regressing bug #]: bug 885962 (not a regression)
[User impact if declined]: mixed content blocking notification has wrong text size
[Describe test coverage new/current, TBPL]: no automated tests, verified on Nightly
[Risks and why]: low-risk change to text size style in mixed content blocking notification
[String/UUID change made/needed]: none

This bug has been around a long time, but this is a pretty simple fix, so it would be nicer to ship it sooner rather than later.
Attachment #8472530 - Flags: approval-mozilla-aurora?
Attachment #8472530 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Verified as fixed in build 33.0a2 (2014-08-20);
Device: Samsung Galaxy S4 (Android 4.4.2)
status-firefox33: fixed → verified
Keywords: verifyme
Flags: qe-verify+
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.