917970 - Large text on door-hanger for mixed content blocking on high DPI devices

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

Attachment: device-2013-09-18-142608.png

See screenshot. DPI issue?

Steps to Reproduce

i) http://fhr.cdn.mozilla.net/en-US/mobile/?v=1#raw
ii) Tap the protection shield

--
Samsung Galaxy S4 (Android 4.3)
Nightly (09/18)

Comment 1

[:Margaret Leibovic]

Is this actually a regression? It was probably caused by me doing something dumb in my patch for bug 885962. It does look like a DPI issue, I don't think I've ever tested on a screen with as high resolution as the S4.

Comment 2

[Aaron Train [:aaronmt]]

Yeah looks correct on the Nexus 4.

Comment 4

[:Margaret Leibovic]

This would be a good bug for someone familiar with Android UI. Like I mentioned in comment 1, we're likely just doing something wrong with how we're setting the text size.

Comment 5

[Aaron Train [:aaronmt]]

Attachment: caution door-hanger screenshot

There's also the caution door-hanger screenshot which is ridiculously big.

Comment 6

[Aaron Train [:aaronmt]]

Attachment: screenshot.png

Still comically large (08/13).

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Margaret - Time to just do it?

Comment 8

[:Margaret Leibovic]

(In reply to Mark Finkle (:mfinkle) from comment #7)
> Margaret - Time to just do it?

Sure, I can look into making a patch.

Comment 9

[:Margaret Leibovic]

Attachment: Use correct text size for mixed content blocking notification

This patch uses styles instead of manually trying to change the text size. Aaron verified that this fixes the problem.

Comment 10

[Lucas Rocha (:lucasr)]

Comment on attachment 8472530 [details] [diff] [review]
Use correct text size for mixed content blocking notification

Review of attachment 8472530 [details] [diff] [review]:
-----------------------------------------------------------------

?android:attr/textAppearanceMedium is not resolving correctly it seems.

Comment 11

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/d53b311f9e35

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d53b311f9e35

Comment 13

[:Margaret Leibovic]

Comment on attachment 8472530 [details] [diff] [review]
Use correct text size for mixed content blocking notification

Approval Request Comment
[Feature/regressing bug #]: bug 885962 (not a regression)
[User impact if declined]: mixed content blocking notification has wrong text size
[Describe test coverage new/current, TBPL]: no automated tests, verified on Nightly
[Risks and why]: low-risk change to text size style in mixed content blocking notification
[String/UUID change made/needed]: none

This bug has been around a long time, but this is a pretty simple fix, so it would be nicer to ship it sooner rather than later.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/0fe131231886

Comment 15

[Flaviu Cos]

Verified as fixed in build 33.0a2 (2014-08-20);
Device: Samsung Galaxy S4 (Android 4.4.2)