918053 - TA__discoverSources should use Debugger.Source

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Right now we iterate through scripts and infer sources via URL, instead we should either a) iterate through scripts and infer sources via script.source, or b) use dbg.findSources, if it is implemented in time.

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: bug-918053-discover-sources-debugger-source.patch

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 827081 [details] [diff] [review]
bug-918053-discover-sources-debugger-source.patch

Review of attachment 827081 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/devtools/server/actors/script.js
@@ +1572,4 @@
>      }
>  
> +    return all([this.sources.sourcesForScript(script)
> +                for ([source, script] of sourcesToScripts)]);

Since you don't use |source|, using [, script] would avoid the extra (large) allocation.

Comment 3

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

https://hg.mozilla.org/integration/fx-team/rev/9150f892e4ea

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9150f892e4ea