Closed Bug 918053 Opened 8 years ago Closed 8 years ago

TA__discoverSources should use Debugger.Source

Categories

(DevTools :: Debugger, defect, P2)

x86
macOS
defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 28

People

(Reporter: fitzgen, Assigned: fitzgen)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

Right now we iterate through scripts and infer sources via URL, instead we should either a) iterate through scripts and infer sources via script.source, or b) use dbg.findSources, if it is implemented in time.
Assignee: nobody → nfitzgerald
Priority: -- → P2
Comment on attachment 827081 [details] [diff] [review]
bug-918053-discover-sources-debugger-source.patch

Review of attachment 827081 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/devtools/server/actors/script.js
@@ +1572,4 @@
>      }
>  
> +    return all([this.sources.sourcesForScript(script)
> +                for ([source, script] of sourcesToScripts)]);

Since you don't use |source|, using [, script] would avoid the extra (large) allocation.
Attachment #827081 - Flags: review?(past) → review+
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/9150f892e4ea
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 28
Whiteboard: [qa-]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.