91808 - Sanity check duplicates table.

Status: RESOLVED FIXED

(Bugzilla :: Administration, task, P3)

Description

[Matthew Tuck [:CodeMachine]]

I added a few referential checks for the new duplicates table to a patch on bug
#76140.

However, we could go further.  In particular:

Check that each bug that's been marked duplicate has an entry in the duplicates
table.
Check that each bug that has an entry in the duplicates table that's been marked
duplicate.

In particular the second check goes further than the existing referential check,
so maybe it should be removed from the above mentioned patch.

But anyway, rather than doing these two checks separately, I suggest we do them
together, in a similar way as a list merge:

(1)  Get a sorted list of bugs marked duplicate as per the bugs table.
(2)  Get a sorted list of bugs marked duplicate as per the duplicates table.
(3)  Compare the two lists using a similar technique as you would to merge the
lists into one sorted list - continually compare the heads.  If both heads are
the same, remove them, otherwise remove the lesser head and split out an error.

Comment 1

[Matthew Tuck [:CodeMachine]]

Attachment: Fix.

Comment 2

[Matthew Tuck [:CodeMachine]]

The above patch has comments in the style of bug #93667.

Comment 3

[Matthew Tuck [:CodeMachine]]

I did the patch in two different parts, because I wasn't sure if and how I could
do a symmetric outer join, and there doesn't seem to be a way to process two
queries at once.  It's only sanity check, so it's no biggie.

Comment 4

[Matthew Tuck [:CodeMachine]]

Moving to new Bugzilla product ...

Comment 5

[Matthew Tuck [:CodeMachine]]

Attachment: New version.

Comment 6

[Jacob Steenhagen]

Comment on attachment 47992 [details] [diff] [review]
New version.

OK, this looks good to me.    r=jake
Suggest a second review.

Comment 7

[Jacob Steenhagen]

-> Patch writer

Comment 8

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 47992 [details] [diff] [review]
New version.

MattyT said that he would add some stuff in between the declaration of my @badbugs and @badbugs = ();  possibly in a different patch.  Apart from that minor nit, this patch looks fine, although I haven't tested it.  r= caillon.

Comment 9

[Dave Miller [:justdave]]

checked in.

Comment 10

[Jacob Steenhagen]

MySQL 3.22 doesn't support inner join :(

Comment 11

[Matthew Tuck [:CodeMachine]]

Oh grr, now I remember.  One to add to the HACKER's guide.

Comment 12

[Matthew Tuck [:CodeMachine]]

Attachment: Fix.

Comment 13

[Matthew Tuck [:CodeMachine]]

Added INNER JOIN to bug #97976.

Comment 14

[Dave Miller [:justdave]]

Comment on attachment 48516 [details] [diff] [review]
Fix.

r= justdave (no 2nd review needed)

Comment 15

[Dave Miller [:justdave]]

checked in.