Disable pinch-zoom overscroll

VERIFIED FIXED in Firefox 27

Status

()

VERIFIED FIXED
5 years ago
2 years ago

People

(Reporter: wesj, Assigned: wesj)

Tracking

Trunk
Firefox 27
x86_64
Linux
Points:
---

Firefox Tracking Flags

(firefox27 verified)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Since we're disabling overscroll, we should also not allow pinch zooming beyond the page boundaries.
(Assignee)

Comment 1

5 years ago
Created attachment 807246 [details] [diff] [review]
Patch v1

Here's a pretty simple way to do this. There may be something more efficient?
Attachment #807246 - Flags: review?(bugmail.mozilla)
Comment on attachment 807246 [details] [diff] [review]
Patch v1

Review of attachment 807246 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/gfx/JavaPanZoomController.java
@@ +1182,5 @@
> +
> +            // If overscroll is diabled, prevent zooming outside the normal document pans.
> +            if (mX.getOverScrollMode() == View.OVER_SCROLL_NEVER || mY.getOverScrollMode() == View.OVER_SCROLL_NEVER) {
> +                target = getValidViewportMetrics(target);
> +            }

Does the scrollBy call above this need to be clamped somehow too? It should only affect the toolbar hiding behaviour so if that looks fine with this then this patch should be sufficient.
Attachment #807246 - Flags: review?(bugmail.mozilla) → review+
(Assignee)

Comment 3

5 years ago
Toolbar showing/hiding seems fine with this. It will pan in or out if you pan while pinch-zooming, but will snap to an edge when you let go.

https://hg.mozilla.org/integration/fx-team/rev/dc02e5225fbe
https://hg.mozilla.org/mozilla-central/rev/dc02e5225fbe
Assignee: nobody → wjohnston
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 27

Updated

5 years ago
Status: RESOLVED → VERIFIED
status-firefox27: --- → verified
You need to log in before you can comment on or make changes to this bug.