Closed
Bug 918086
Opened 11 years ago
Closed 11 years ago
Disable pinch-zoom overscroll
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox27 verified)
VERIFIED
FIXED
Firefox 27
Tracking | Status | |
---|---|---|
firefox27 | --- | verified |
People
(Reporter: wesj, Assigned: wesj)
Details
Attachments
(1 file)
1.31 KB,
patch
|
kats
:
review+
|
Details | Diff | Splinter Review |
Since we're disabling overscroll, we should also not allow pinch zooming beyond the page boundaries.
Assignee | ||
Comment 1•11 years ago
|
||
Here's a pretty simple way to do this. There may be something more efficient?
Attachment #807246 -
Flags: review?(bugmail.mozilla)
Comment 2•11 years ago
|
||
Comment on attachment 807246 [details] [diff] [review]
Patch v1
Review of attachment 807246 [details] [diff] [review]:
-----------------------------------------------------------------
::: mobile/android/base/gfx/JavaPanZoomController.java
@@ +1182,5 @@
> +
> + // If overscroll is diabled, prevent zooming outside the normal document pans.
> + if (mX.getOverScrollMode() == View.OVER_SCROLL_NEVER || mY.getOverScrollMode() == View.OVER_SCROLL_NEVER) {
> + target = getValidViewportMetrics(target);
> + }
Does the scrollBy call above this need to be clamped somehow too? It should only affect the toolbar hiding behaviour so if that looks fine with this then this patch should be sufficient.
Attachment #807246 -
Flags: review?(bugmail.mozilla) → review+
Assignee | ||
Comment 3•11 years ago
|
||
Toolbar showing/hiding seems fine with this. It will pan in or out if you pan while pinch-zooming, but will snap to an edge when you let go.
https://hg.mozilla.org/integration/fx-team/rev/dc02e5225fbe
Comment 4•11 years ago
|
||
Assignee: nobody → wjohnston
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 27
Updated•11 years ago
|
Status: RESOLVED → VERIFIED
status-firefox27:
--- → verified
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•