Let NeckoParent get the app:// uri when remoting file opening.

RESOLVED FIXED in Firefox 27

Status

()

defect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: fabrice, Assigned: fabrice)

Tracking

unspecified
mozilla27
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox27 fixed)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment, 1 obsolete attachment)

11.57 KB, patch
jduell.mcbugs
: review+
Details | Diff | Splinter Review
We need that for bug 882186 where we'll need to whitelist a single trusted uri.
Posted patch patch (obsolete) — Splinter Review
Attachment #806908 - Flags: review?(jduell.mcbugs)
Comment on attachment 806908 [details] [diff] [review]
patch

Review of attachment 806908 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/ipc/NeckoParent.cpp
@@ +448,5 @@
>          printf_stderr("NeckoParent::AllocPRemoteOpenFile: "
>                        "FATAL error: app without webapps-manage permission is "
>                        "requesting file '%s' but is only allowed to open its "
> +                      "own application.zip at %s: KILLING CHILD PROCESS\n",
> +                      requestedPath.get(), mustMatch.get());

thanks for adding that :)
Attachment #806908 - Flags: review?(jduell.mcbugs) → review+
Fixed locally, waiting for green try:
https://tbpl.mozilla.org/?tree=Try&rev=83961272a1ba
Posted patch patch v2Splinter Review
Jason, this is basically the same patch, but using OptionalURIParams to fail gracefully when we have no app uri.
Attachment #806908 - Attachment is obsolete: true
Attachment #807542 - Flags: review?(jduell.mcbugs)
Attachment #807542 - Flags: review?(jduell.mcbugs) → review+
https://hg.mozilla.org/mozilla-central/rev/400260c0b569
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.