918090 - Let NeckoParent get the app:// uri when remoting file opening.

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[[:fabrice] Fabrice Desré]

We need that for bug 882186 where we'll need to whitelist a single trusted uri.

Comment 1

[[:fabrice] Fabrice Desré]

Attachment: patch

Comment 2

[Jason Duell]

Comment on attachment 806908 [details] [diff] [review]
patch

Review of attachment 806908 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/ipc/NeckoParent.cpp
@@ +448,5 @@
>          printf_stderr("NeckoParent::AllocPRemoteOpenFile: "
>                        "FATAL error: app without webapps-manage permission is "
>                        "requesting file '%s' but is only allowed to open its "
> +                      "own application.zip at %s: KILLING CHILD PROCESS\n",
> +                      requestedPath.get(), mustMatch.get());

thanks for adding that :)

Comment 3

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/integration/b2g-inbound/rev/febd08d19087

Comment 4

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/b2g-inbound/rev/5b9218f200db for xpcshell bustage.

Comment 5

[[:fabrice] Fabrice Desré]

Fixed locally, waiting for green try:
https://tbpl.mozilla.org/?tree=Try&rev=83961272a1ba

Comment 6

[[:fabrice] Fabrice Desré]

Attachment: patch v2

Jason, this is basically the same patch, but using OptionalURIParams to fail gracefully when we have no app uri.

Comment 7

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/integration/b2g-inbound/rev/400260c0b569

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/400260c0b569