Closed
Bug 918107
Opened 11 years ago
Closed 11 years ago
[MP] Change - Fire What's New page for Aurora Windows 8 Users
Categories
(Firefox :: General, defect, P1)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 26
People
(Reporter: lforrest, Assigned: Gavin)
References
Details
(Whiteboard: [preview] feature=change c=tbd u=tbd p=0)
Attachments
(2 files)
1.65 KB,
patch
|
mbrubeck
:
review+
jaws
:
review+
bajaj
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
1.40 KB,
patch
|
robert.strong.bugs
:
review+
|
Details | Diff | Splinter Review |
We'd like to let Aurora Windows 8 users know that a Firefox Metro preview is now available for them to start using. Let's use the What's New functionality to trigger a SUMO page that can show them this messaging.
URL to show: A SUMO page MVerdi is creating
Launch Date: With the Aurora update this Friday
More details here:
https://docs.google.com/a/mozilla.com/document/d/1kTBXys3Mk-IWLMU4iAxVNxe1bP6b9ga6r5i7RDm7_5w/edit?usp=sharing
Comment 1•11 years ago
|
||
Also needinfo, :nthomas from releng here for input as this is targeted to hit the users when aurora updates are enabled.
:nthomas, is it possible to have the a targeted what's new(per OS) for aurora audience ?
Flags: needinfo?(nthomas)
Assignee | ||
Comment 2•11 years ago
|
||
Doing this in the update snippets is probably easier than in-product (easier to control per-OS). Not sure if we can do OS minor version or per-locale differentiation, though?
Comment 3•11 years ago
|
||
If needed, here is the documentation on linking to a sumo article https://support.mozilla.org/en-US/kb/mozilla-developer-guide-linking-support-articles
Comment 4•11 years ago
|
||
In the update server we can do something by locale, and by OS but only at the level of Windows vs Mac. So en-US and all versions of windows would be possible (this would be done with snippets). Have you thought about locales we want to do this for ? I see from the link in comment #3 we don't have to have a different link for each locale, which is good.
There's no mechanism to target just Windows 8 users, at least not without code modifications to the update server so probably we don't want to go there.
Flags: needinfo?(nthomas)
Assignee | ||
Comment 5•11 years ago
|
||
We could target Windows 8 users only with some custom in-product code, I suppose.
Comment 6•11 years ago
|
||
(In reply to :Gavin Sharp (use gavin@gavinsharp.com for email) from comment #5)
> We could target Windows 8 users only with some custom in-product code, I
> suppose.
How easy/hard would that be :gavin given we are targeting the patch to land by tomorrow on aurora so Friday's updates have them ? Any recommendations on who could help with that if that's doable ?
Comment 7•11 years ago
|
||
Jim, Brian - could we get your input on the google doc in comment#0, to confirm we're starting with the right information about how Firefox will behave when updating to a metro-enabled build. Can we set a metro-only pref to load a whatsnew/firstrun page ?
Comment 8•11 years ago
|
||
ie, can we set
pref("startup.homepage_override_url","<somewhere on sumo>");
in browser/metro/profile/metro.js, so it only affects people running the metro.
Comment 9•11 years ago
|
||
That pref only lives in the Metro profile, which is different than the Desktop profile. I think you want to show a message on the Desktop profile, so we'd need a pref inside the firefox.js pref's file. Then we'd need to conditionally show it if the OS is win8.0 or later.
Comment 10•11 years ago
|
||
The User Story in the google doc lead me to believe that our current code would start Aurora in Metro mode after the update. I verified that doesn't actually happen (by taking a 25.0a2 Aurora build and updating on the auroratest channel to 26.0a2). So comment #9 makes sense, and comment #8 is no help.
Comment 11•11 years ago
|
||
I seen Comment 3 but do we have a final URL that would need to be shown?
CC'ing Marco to see if he can assign someone to this.
Whiteboard: [preview-triage]
Updated•11 years ago
|
Blocks: metrov1backlog
Summary: [Firefox Metro] Fire What's New page for Aurora Windows 8 Users → Change - Fire What's New page for Aurora Windows 8 Users
Whiteboard: [preview-triage] → [preview-triage] feature=change c=tbd u=tbd p=0
Reporter | ||
Comment 12•11 years ago
|
||
MVerdi should be able to provide a placeholder URL to use here. Stay tuned.
Comment 13•11 years ago
|
||
Can someone help confirm that we can trigger a What's New page on any aurora update and a major version change (25.0a2 -> 26.0a2) in not necessary ?
Comment 14•11 years ago
|
||
Comment from Jim regarding implementation, "We've never made use of startup.homepage_override_url in metro, might work might not. either way shouldn't take much effort/time."
Comment 15•11 years ago
|
||
(In reply to bhavana bajaj [:bajaj] from comment #13)
> Can someone help confirm that we can trigger a What's New page on any aurora
> update and a major version change (25.0a2 -> 26.0a2) in not necessary ?
NI on :nthomas here.
Flags: needinfo?(nthomas)
Comment 16•11 years ago
|
||
(In reply to Marco Mucci [:MarcoM] from comment #14)
> Comment from Jim regarding implementation, "We've never made use of
> startup.homepage_override_url in metro, might work might not. either way
> shouldn't take much effort/time."
In this case we're talking about making use of the Desktop What's New tab to let our Desktop users know they just got a Metro launcher tile installed to their Start screen or All Apps screen and to go test it out.
Comment 17•11 years ago
|
||
I spoke with Asa and this bug is not a blocker for uplift.
Assignee | ||
Comment 18•11 years ago
|
||
(In reply to bhavana bajaj [:bajaj] from comment #13)
> Can someone help confirm that we can trigger a What's New page on any aurora
> update and a major version change (25.0a2 -> 26.0a2) in not necessary ?
Two options:
- in client: doing it just once without it being on a version update is complicated. Doing it on the major version update is relatively easy.
- in the snippets: easy to do any time, but can't target specific versions of Windows (would show for all versions)
Comment 19•11 years ago
|
||
Here's the SUMO url to show (doesn't have content yet): https://support.mozilla.org/kb/good-news-firefox-now-touch-friendly
Assignee | ||
Comment 20•11 years ago
|
||
I pushed a patch to try:
https://tbpl.mozilla.org/?tree=Try&rev=805b3e240236
I think it will be sufficient, but it hasn't been tested yet.
Comment 21•11 years ago
|
||
Requesting juan, to help verify this once the try build is out.
Keywords: verifyme
QA Contact: jbecerra
Assignee | ||
Comment 23•11 years ago
|
||
The build just finished:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/gsharp@mozilla.com-805b3e240236/try-win32/
The behavior is that the page in comment 19 should open on upgrade from a different version than 26.0a2, for all locales, but only on Windows 8 or later. It shouldn't show up on subsequent startups or on other platforms.
Comment 24•11 years ago
|
||
Tested on Windows 8 by upgrading from Aurora 25.0a2 to the Try build from comment 23. I can verify that it shows the special page on first run after upgrade, and not on second run.
Updated•11 years ago
|
Assignee: nobody → gavin.sharp
Blocks: MetroPreviewRelease
Priority: -- → P1
Summary: Change - Fire What's New page for Aurora Windows 8 Users → [MP] Change - Fire What's New page for Aurora Windows 8 Users
Whiteboard: [preview-triage] feature=change c=tbd u=tbd p=0 → [preview] feature=change c=tbd u=tbd p=0
Assignee | ||
Comment 25•11 years ago
|
||
I tested win 8 (works as expected), and win7 (page doesn't show up), seems to be OK.
Assignee | ||
Updated•11 years ago
|
OS: Mac OS X → All
Hardware: x86 → All
Updated•11 years ago
|
Assignee | ||
Comment 26•11 years ago
|
||
The intent is to land this on Aurora only, then back it out at some point later.
Attachment #807419 -
Flags: review?
Assignee | ||
Updated•11 years ago
|
Flags: needinfo?(nthomas)
Updated•11 years ago
|
Attachment #807419 -
Flags: review? → review+
Updated•11 years ago
|
Attachment #807419 -
Flags: review+
Assignee | ||
Comment 27•11 years ago
|
||
Comment on attachment 807419 [details] [diff] [review]
patch
[Approval Request Comment]
Bug caused by (feature/regressing bug #): n/a
User impact if declined: no what's new page
Testing completed (on m-c, etc.): manual testing from mbrubeck/gavin
Risk to taking this patch (and alternatives if risky): low risk, hooks in to the existing whatsnew page mechanism, and only as a fallback
String or IDL/UUID changes made by this patch: none
We'll need to remember to back this out eventually, I will file a tracking bug.
Attachment #807419 -
Flags: approval-mozilla-aurora?
Updated•11 years ago
|
Attachment #807419 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 28•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
status-firefox26:
--- → fixed
tracking-firefox26:
--- → +
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
Updated•11 years ago
|
status-firefox27:
--- → wontfix
Comment 29•11 years ago
|
||
You all have done an amazing job on crazy short notice. Thank you so much for pulling this together. It will absolutely have a significant impact growing our Metro testing community.
Assignee | ||
Comment 30•11 years ago
|
||
This test doesn't expect this hack, so I disabled the portions of it that are failing, without looking too closely. Since this is a short-lived hack I don't think that's a big deal.
Attachment #807543 -
Flags: review?(robert.bugzilla)
Assignee | ||
Comment 31•11 years ago
|
||
Pushed that as a bustage fix:
https://hg.mozilla.org/releases/mozilla-aurora/rev/330b68ae1583
![]() |
||
Comment 32•11 years ago
|
||
Comment on attachment 807543 [details] [diff] [review]
disable portion of test
File a followup to remove the hack and re-enable the test
Attachment #807543 -
Flags: review?(robert.bugzilla) → review+
Assignee | ||
Comment 33•11 years ago
|
||
Already on file as bug 918514.
Comment 34•11 years ago
|
||
Tested on 2013-09-20 using two touch-enabled machines running Windows 8, Win.8.1, and one WinXP VM. I first installed an older version of Aurora and modified the update channel to the auroratest channel. After going through the update to the latest Aurora (9/20) I was able to see a landing page:
https://support.mozilla.org/en-US/kb/good-news-firefox-now-touch-friendly
On Win8 and Win8.1 but not on WinXP.
Keywords: verifyme
You need to log in
before you can comment on or make changes to this bug.
Description
•