918124 - Collection curators API suffers from caching issues

Status: VERIFIED FIXED

(Marketplace Graveyard :: API, defect, P2)

Description

[Matt Basta [:basta]]

Adding and removing curators returns a list that does not reflect the changes made by the request. I.e.: adding a curator returns a list of the collection's curators that does not include the most recently added curator.

Comment 2

[Allen Short [:ashort]]

how i this different from 917336?

Comment 3

[Matt Basta [:basta]]

(In reply to Allen Short [:ashort] from comment #2)
> how i this different from 917336?

This one is about collection curators, that one is about collections.

Comment 4

[Matt Basta [:basta]]

It seems that this is probably a caching issue. It doesn't seem to return an empty list anymore when you're adding the first curator, but the second curator you add has the issue. Also, the API-Pinned header is set to true.

Comment 5

[Chuck Harmston [:chuck]]

This one was a caching issue; cache-machine doesn't appear to invalidate caches when an M2M field is modified.

https://github.com/mozilla/zamboni/compare/910ebd5bce02...bd274d3ca7b8

There are potential scale implications with this commit; since we're invalidating UserProfile objects, there are a large number of unrelated querysets that could also be invalidated as a result.

[qa-] because the rocketfuel client team is in the best place to validate this.

Comment 6

[Matt Basta [:basta]]

I'm still seeing the issue on -dev, for both adding as well as removing curators to a collection. All of the requests show `API-Pinned: true`

Comment 7

[Chuck Harmston [:chuck]]

Potential fix to a theory that it wasn't working due to a latency/race condition kind of issue:

https://github.com/mozilla/zamboni/compare/bd274d3ca7b8...ac80caca0bc9

Comment 8

[Matt Basta [:basta]]

Seems to be good now!