918164 - Add -FS option to NSS config when using VS2013

Status: RESOLVED FIXED

(NSS :: Build, defect, P2)

Description

[Makoto Kato [:m_kato]]

see bug 915973.

Comment 1

[Xavier Fung]

I have reported Bug 932171? which seems related to NSS and /FS option when building debug builds.

Comment 2

[Rodrigo Silveira [:rsilveira] [:rodms]]

Attachment: 918164.patch

Patch to add -FS to VS2013 and greater.

Comment 5

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

We should check this in; who can r+?

Comment 6

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Comment on attachment 832069 [details] [diff] [review]
918164.patch

Review of attachment 832069 [details] [diff] [review]:
-----------------------------------------------------------------

I tested this both in the standalone NSS tree and a Gecko build tree. It doesn't seem to have any effect in the standalone NSS tree (i.e. doesn't seem to make things notably slower) and it does fix the build issue with VS2013 that we have in the Gecko tree.

::: security/nss/coreconf/WIN32.mk
@@ +174,5 @@
>       -we4064 -we4078 -we4087 -we4090 -we4098 -we4390 -we4551 -we4553 -we4715
> +
> +	 ifeq ($(_MSC_VER_GTE18),1)
> +	    OS_CFLAGS += -FS
> +	endif

There's an extra space before "ifeq" and tab+spaces instead of tab+tab before OS_CFLAGS += -FS. I will correct both of those issues when I check in the patch.

Comment 7

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Attachment: fix-whitespace.patch

Comment 8

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

http://hg.mozilla.org/projects/nss/rev/56dcda67db44
http://hg.mozilla.org/projects/nss/rev/ebe34884a3a0

Comment 9

[Wan-Teh Chang]

Attachment: Fix coding style nits

1. Change "GTE" to "GE" because 'ge' is the common "greater-than-or-equal"
in scripting languages.

2. Fix indentation.

I've checked in the patch to save time:
https://hg.mozilla.org/projects/nss/rev/4db08249d5a1

Please do a post-commit review. Thanks.