Closed Bug 918177 Opened 10 years ago Closed 10 years ago

--enable-tests build fails with gcc_hidden.h on libc++: '_ZNSt3__112basic_stringIcNS_11char_traitsIcEENS_9allocatorIcEEED1Ev' et al. are hidden

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Platform:
All
FreeBSD
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox26 fixed, firefox27 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla27
Tracking Flags:
Tracking Status
firefox26 --- fixed
firefox27 --- fixed

People

(Reporter: jbeich, Assigned: jbeich)

References

(
URL
)

Details

Attachments

(1 file)

expose <iosfwd>
1.34 KB, patch
glandium
: review+
lsblakk
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
FreeBSD 10 no longer ships with libstdc++-4.2 on tier1 platforms[1]. This exposes breakage with libc++ and pragma visibility (via gcc_hidden.h) in media/webrtc/trunk/testing/gtest_gtest/gtest-test-part.o while the build stops a bit later, in signaling/test at link time.

[1] http://svnweb.freebsd.org/changeset/base/255321
Attached patch expose <iosfwd> — — Splinter Review 

        Attachment #807034 -
        Flags: review?(mh+mozilla)

        Attachment #807034 -
        Flags: review?(mh+mozilla) → review+

    
  
Keywords: checkin-needed

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/3c1df3f2ca71
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27

    
    

    
  
Jan, i think you want this backported to aurora since it's also affected..

    
    

    
  
Comment on attachment 807034 [details] [diff] [review]
expose <iosfwd>

[Approval Request Comment]
Bug caused by: exposed on FreeBSD by bug 807492, existed before
User impact if declined: broken build on libc++ platforms with gcc_hidden.h (FreeBSD and maybe Linux, OS X)
Testing completed: landed on m-c
Risk to taking this patch: none
String or IDL/UUID changes made by this patch:

        Attachment #807034 -
        Flags: approval-mozilla-aurora?

        Attachment #807034 -
        Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

    
  
Product: Core → Firefox Build System

          You need to log in
          before you can comment on or make changes to this bug.