918223 - Aurora stopped adding words to persdict.dat

Status: VERIFIED FIXED

(Core :: Spelling checker, defect)

Description

[Igor Mackeev]

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:25.0) Gecko/20100101 Firefox/25.0 (Beta/Release)
Build ID: 20130916004002

Steps to reproduce:

I added a new word to user dictionary by pressing the Add to dictionary item on the right-click menu. 


Actual results:

The squiggly line under the word disappeared and all subsequent entries of this word were treated as 'known' (no underlining) during the session.
When I closed and reopened Aurora, however, and then typed this word again, it was all new to the spellchecker (underlined again).
I found out that it had not been added to persdict.dat file at all.


Expected results:

It should have been added to persdict.dat. Actually, I had had no problems with this until August 21 (this is the last date persdict. dat was modified). I don't know what nightly exactly is responsible for this problem: I don't add new words too  often. But it should have started sometime around end of August beginning of September.

Comment 1

[Alice0775 White]

I can reproduce.
http://hg.mozilla.org/releases/mozilla-beta/rev/143e8c67cf1b
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:25.0) Gecko/20100101 Firefox/25.0 ID:20130917123208
http://hg.mozilla.org/releases/mozilla-aurora/rev/0322470077b7
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0 ID:20130918004001
http://hg.mozilla.org/mozilla-central/rev/ab4ccf3d6b60
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:27.0) Gecko/20100101 Firefox/27.0 ID:20130918030202

Comment 2

[Alice0775 White]

Regression window(m-c)
Good:
http://hg.mozilla.org/mozilla-central/rev/b3ff36cb6a1a
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:25.0) Gecko/20130710 Firefox/25.0 ID:20130710064457
Bad:
http://hg.mozilla.org/mozilla-central/rev/dde4dcd6fa46
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:25.0) Gecko/20130710 Firefox/25.0 ID:20130710105040
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=b3ff36cb6a1a&tochange=dde4dcd6fa46

Regression window(m-i)
Good:
http://hg.mozilla.org/integration/mozilla-inbound/rev/b61b7f2e0d0b
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:25.0) Gecko/20130709 Firefox/25.0 ID:20130709145300
Bad:
http://hg.mozilla.org/integration/mozilla-inbound/rev/d42a2a82f3d2
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:25.0) Gecko/20130709 Firefox/25.0 ID:20130709151225
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=b61b7f2e0d0b&tochange=d42a2a82f3d2

Regressed by:
d42a2a82f3d2	Olli Pettay — bug 789919, (snow-white) make addref/release of CCable objects faster by removing indirect refcnt increase/decrease, r=mccr8, test changes r=ehsan

Comment 3

[Alice0775 White]

Attachment: spellcheck4.html

STR
1. Create New profile
2. Open Attached html
3. Type any wrong word 
4. Right click on a misspelled word And Choose "Add to Dictionary"
5. Exit Browser
   --- observe whether persdict.dat file is created in profile folder.
6. Start browser again
7. Open Attached html again
3. Type the wrong word 
   --- observe red squiggly line under the word

Actual Results:
persdict.dat file is not created.
underlined again.

Expected Results:
persdict.dat file should be created.
No underlined.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Looking (sounds like a bug in mozPersonalDictionary.cpp)

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Aha, bug in mozSpellChecker. dtor does stuff it shouldn't do.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

As far as I see, this bug has been there forever. If mozSpellChecker has been
leaked or not collected during shutdown (and these days we explicitly disable shutdown CCs), http://mxr.mozilla.org/mozilla-central/source/extensions/spellcheck/src/mozSpellChecker.cpp#32 may not be called, and EndSession is possibly not called.

profile-do-change usage looks a bit bogus, but I don't want to change that
in this regression bug.

Comment 7

[(no longer active)]

Comment on attachment 807183 [details] [diff] [review]
patch

Actually, this should happen in profile-before-change.  r=me with that.

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Don't know why, given the current shutdown setup, but ok, in principle that is the right thing to do.

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

Comment 11

[Olli Pettay [:smaug][[e-mail]]]

Attachment: for branches

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 789919, although the problem has been there for ages
User impact if declined: User dictionary is not saved always
Testing completed (on m-c, etc.): about to land m-i. tested locally
Risk to taking this patch (and alternatives if risky): Should be low risk
String or IDL/UUID changes made by this patch:NA

Comment 12

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 807217 [details] [diff] [review]
patch

I think this should actually apply to the latest Aurora.

Comment 13

[(no longer active)]

(In reply to comment #8)
> Don't know why, given the current shutdown setup, but ok, in principle that is
> the right thing to do.

Yeah, in principle we're supposed to save everything that we need by profile-before-change.

Comment 14

[Olli Pettay [:smaug][[e-mail]]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/01e5e4697b36

Comment 15

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/01e5e4697b36

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/5a81435e6cc7
https://hg.mozilla.org/releases/mozilla-beta/rev/ed7ce69c6603

Comment 17

[Ada [:adalucinet]]

Mozilla/5.0 (Windows NT 6.1; rv:25.0) Gecko/20100101 Firefox/25.0
Mozilla/5.0 (Windows NT 6.1; rv:27.0) Gecko/20100101 Firefox/27.0 
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:25.0) Gecko/20100101 Firefox/25.0 
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:27.0) Gecko/20100101 Firefox/27.0
Mozilla/5.0 (X11; Linux i686; rv:25.0) Gecko/20100101 Firefox/25.0
Mozilla/5.0 (X11; Linux i686; rv:27.0) Gecko/20100101 Firefox/27.0

Reproduced with Nightly 25.0a1(Build ID: 20130713030205). 
Verified as fixed with STR from comment 3 on Firefox 25 beta 2 (Build ID: 20130923194050) and latest Nightly (Build ID: 20130924030202): the persdict.dat file is created in the profile folder when a word is added to dictionary.

Comment 18

[Ekanan Ketunuti]

Verified fixed in Nightly 27.0a1 buildid 20131007030203, Aurora 26.0a2 buildid 20131007004003.