918226 - Australis: expose "Work Offline" in the developer subview

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[:Gijs (he/him)]

Per discussion on #fx-team, this is now less exposed on non-Mac, because previously the appmenu's developer menu had an item for it. Now there's nothing at all. That might be OK. Or it might not be. But we should make a conscious decision either way.

Smallest amount of work / non-decision is probably adding it to the developer subview again, for parity with the app menu on current m-c.

Comment 1

[Florian Bender]

This is an important developer option for testing offline behaviour of WebApps (sometimes you don't want to turn off WiFi / unplug the network for the whole system but just the browser), so please move this to the Dev menu.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Wasn't mhoye working on this? He showed me a patch that did this yesterday... is this that bug? Or are we duped here?

Comment 3

[Mike Hoye [:mhoye]]

That patch went to bug 565564 - it's incorrect, incidentally, does the wrong thing on Windows - but was denied review pending a discussion about the fate of the feature. 

I'm going to correct the patch, because I'm confident my argument - "web & webapp developers still want this but it's a pretty big footgun to leave lying around and should not be a tier-1 menu item" will carry the day.

But that's where we are now, I think.

Comment 4

[:Gijs (he/him)]

(In reply to Mike Hoye [:mhoye] from comment #3)
> That patch went to bug 565564 - it's incorrect, incidentally, does the wrong
> thing on Windows - but was denied review pending a discussion about the fate
> of the feature. 
> 
> I'm going to correct the patch, because I'm confident my argument - "web &
> webapp developers still want this but it's a pretty big footgun to leave
> lying around and should not be a tier-1 menu item" will carry the day.
> 
> But that's where we are now, I think.

Right, but it's a patch for m-c. If that will get us the developer tools menu item for free, and lands, great. Otherwise, this bug needs its own resolution, so let's keep it open for now. :-)

Comment 5

[Mike de Boer [:mikedeboer]]

Madhava, could you spend a few brain-cycles on this question: What to do with the Work Offline menu option on Windows?

Is it a good-enough solution to tuck it into the Developer Subview?

Comment 6

[:Gavin Sharp [email: [e-mail]]]

We should do what comment 0 suggests:

> Smallest amount of work / non-decision is probably adding it to the developer
> subview again, for parity with the app menu on current m-c.

Comment 7

[:Gijs (he/him)]

Updating summary per comment #6

Comment 8

[:Gijs (he/him)]

Attachment: expose 'work offline' in the developer subview,

Comment 9

[:Gijs (he/him)]

Note that I also found a bug on Windows where checked items are indented very differently when the bookmarks menu button is in a toolbar. I'll file a followup for that once this is checked in.

Comment 10

[Mike de Boer [:mikedeboer]]

Comment on attachment 832160 [details] [diff] [review]
expose 'work offline' in the developer subview,

Review of attachment 832160 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good! I also agree with the 2px margin-end for the checkmark pseudo-element.

I hope to get some more good stuff out of bug 878546. Subviews seem kind of an afterthought atm.

Comment 11

[:Gijs (he/him)]

https://hg.mozilla.org/projects/ux/rev/c49faf118145

Comment 12

[:Gijs (he/him)]

Filed bug 938603 for the bookmarks menu issue

Comment 13

[:Gijs (he/him)]

https://hg.mozilla.org/mozilla-central/rev/c49faf118145