918240 - Can possibly remove "Restart required - restart now?" from chrome and remote debugging pref

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Description

[:Gijs (he/him)]

After bug 917706, I *think* restarts are no longer required to toggle chrome/remote debugging - but I'm not familiar with remote debugging besides browser debugging, so I could be wrong...

Looking at:

http://mxr.mozilla.org/mozilla-central/search?string=debugger.remote-enabled&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

http://mxr.mozilla.org/mozilla-central/search?string=debugger.chrome-enabled&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

I'm 99% sure this will Just Work without a restart. The debugger server's openListener checks the live pref, and metro has a pref observer for running the server... so it should be OK? Panos, does that sound accurate?

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

Yes, we should just remove the notification from the panel.

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Remove mentions of restarting in the options panel when toggling the remote and chrome debugging prefs

This should do it, although I haven't tested it yet. Laptop is busy building other patches.

Comment 3

[:Gijs (he/him)]

(In reply to Panos Astithas [:past] from comment #2)
> Created attachment 807740 [details] [diff] [review]
> Remove mentions of restarting in the options panel when toggling the remote
> and chrome debugging prefs
> 
> This should do it, although I haven't tested it yet. Laptop is busy building
> other patches.

I checked quickly - yes, this works. Thanks! :-)

Comment 4

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 807740 [details] [diff] [review]
Remove mentions of restarting in the options panel when toggling the remote and chrome debugging prefs

Yep, works fine and all tests pass.

Comment 5

[Joe Walker [:jwalker]]

Comment on attachment 807740 [details] [diff] [review]
Remove mentions of restarting in the options panel when toggling the remote and chrome debugging prefs

Review of attachment 807740 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, but I think it might be worth asking Mike to take a look - he wrote the original.

Comment 6

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 807740 [details] [diff] [review]
Remove mentions of restarting in the options panel when toggling the remote and chrome debugging prefs

Review of attachment 807740 [details] [diff] [review]:
-----------------------------------------------------------------

I didn't know Mike wrote this code! Mike, does this change look OK?

Comment 7

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 807740 [details] [diff] [review]
Remove mentions of restarting in the options panel when toggling the remote and chrome debugging prefs

Review of attachment 807740 [details] [diff] [review]:
-----------------------------------------------------------------

Yup, looks good to me.

Comment 8

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/integration/fx-team/rev/efab2edc6969

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/efab2edc6969