The default bug view has changed. See this FAQ.

Can possibly remove "Restart required - restart now?" from chrome and remote debugging pref

RESOLVED FIXED in Firefox 27

Status

()

Firefox
Developer Tools: Debugger
P3
normal
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Gijs, Assigned: past)

Tracking

unspecified
Firefox 27
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
After bug 917706, I *think* restarts are no longer required to toggle chrome/remote debugging - but I'm not familiar with remote debugging besides browser debugging, so I could be wrong...

Looking at:

http://mxr.mozilla.org/mozilla-central/search?string=debugger.remote-enabled&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

http://mxr.mozilla.org/mozilla-central/search?string=debugger.chrome-enabled&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

I'm 99% sure this will Just Work without a restart. The debugger server's openListener checks the live pref, and metro has a pref observer for running the server... so it should be OK? Panos, does that sound accurate?
Flags: needinfo?(past)
Yes, we should just remove the notification from the panel.
Flags: needinfo?(past)
Created attachment 807740 [details] [diff] [review]
Remove mentions of restarting in the options panel when toggling the remote and chrome debugging prefs

This should do it, although I haven't tested it yet. Laptop is busy building other patches.
Assignee: nobody → past
Status: NEW → ASSIGNED
Priority: -- → P3
(Reporter)

Comment 3

4 years ago
(In reply to Panos Astithas [:past] from comment #2)
> Created attachment 807740 [details] [diff] [review]
> Remove mentions of restarting in the options panel when toggling the remote
> and chrome debugging prefs
> 
> This should do it, although I haven't tested it yet. Laptop is busy building
> other patches.

I checked quickly - yes, this works. Thanks! :-)
Comment on attachment 807740 [details] [diff] [review]
Remove mentions of restarting in the options panel when toggling the remote and chrome debugging prefs

Yep, works fine and all tests pass.
Attachment #807740 - Flags: review?(jwalker)
Comment on attachment 807740 [details] [diff] [review]
Remove mentions of restarting in the options panel when toggling the remote and chrome debugging prefs

Review of attachment 807740 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, but I think it might be worth asking Mike to take a look - he wrote the original.
Attachment #807740 - Flags: review?(jwalker) → review+
Comment on attachment 807740 [details] [diff] [review]
Remove mentions of restarting in the options panel when toggling the remote and chrome debugging prefs

Review of attachment 807740 [details] [diff] [review]:
-----------------------------------------------------------------

I didn't know Mike wrote this code! Mike, does this change look OK?
Attachment #807740 - Flags: review?(mratcliffe)
Comment on attachment 807740 [details] [diff] [review]
Remove mentions of restarting in the options panel when toggling the remote and chrome debugging prefs

Review of attachment 807740 [details] [diff] [review]:
-----------------------------------------------------------------

Yup, looks good to me.
Attachment #807740 - Flags: review?(mratcliffe) → review+
https://hg.mozilla.org/integration/fx-team/rev/efab2edc6969
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/efab2edc6969
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 27
You need to log in before you can comment on or make changes to this bug.