Last Comment Bug 918240 - Can possibly remove "Restart required - restart now?" from chrome and remote debugging pref
: Can possibly remove "Restart required - restart now?" from chrome and remote ...
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: Developer Tools: Debugger (show other bugs)
: unspecified
: All All
P3 normal (vote)
: Firefox 27
Assigned To: Panos Astithas [:past]
:
: Jason Laster [:jlast]
Mentors:
Depends on: 917706
Blocks:
  Show dependency treegraph
 
Reported: 2013-09-19 02:07 PDT by :Gijs
Modified: 2013-09-24 07:44 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Remove mentions of restarting in the options panel when toggling the remote and chrome debugging prefs (6.24 KB, patch)
2013-09-20 06:38 PDT, Panos Astithas [:past]
jwalker: review+
mratcliffe: review+
Details | Diff | Splinter Review

Description User image :Gijs 2013-09-19 02:07:02 PDT
After bug 917706, I *think* restarts are no longer required to toggle chrome/remote debugging - but I'm not familiar with remote debugging besides browser debugging, so I could be wrong...

Looking at:

http://mxr.mozilla.org/mozilla-central/search?string=debugger.remote-enabled&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

http://mxr.mozilla.org/mozilla-central/search?string=debugger.chrome-enabled&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

I'm 99% sure this will Just Work without a restart. The debugger server's openListener checks the live pref, and metro has a pref observer for running the server... so it should be OK? Panos, does that sound accurate?
Comment 1 User image Panos Astithas [:past] 2013-09-19 02:30:24 PDT
Yes, we should just remove the notification from the panel.
Comment 2 User image Panos Astithas [:past] 2013-09-20 06:38:29 PDT
Created attachment 807740 [details] [diff] [review]
Remove mentions of restarting in the options panel when toggling the remote and chrome debugging prefs

This should do it, although I haven't tested it yet. Laptop is busy building other patches.
Comment 3 User image :Gijs 2013-09-20 06:40:59 PDT
(In reply to Panos Astithas [:past] from comment #2)
> Created attachment 807740 [details] [diff] [review]
> Remove mentions of restarting in the options panel when toggling the remote
> and chrome debugging prefs
> 
> This should do it, although I haven't tested it yet. Laptop is busy building
> other patches.

I checked quickly - yes, this works. Thanks! :-)
Comment 4 User image Panos Astithas [:past] 2013-09-20 11:49:30 PDT
Comment on attachment 807740 [details] [diff] [review]
Remove mentions of restarting in the options panel when toggling the remote and chrome debugging prefs

Yep, works fine and all tests pass.
Comment 5 User image Joe Walker [:jwalker] (needinfo me or ping on irc) 2013-09-22 01:51:28 PDT
Comment on attachment 807740 [details] [diff] [review]
Remove mentions of restarting in the options panel when toggling the remote and chrome debugging prefs

Review of attachment 807740 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, but I think it might be worth asking Mike to take a look - he wrote the original.
Comment 6 User image Panos Astithas [:past] 2013-09-23 02:46:39 PDT
Comment on attachment 807740 [details] [diff] [review]
Remove mentions of restarting in the options panel when toggling the remote and chrome debugging prefs

Review of attachment 807740 [details] [diff] [review]:
-----------------------------------------------------------------

I didn't know Mike wrote this code! Mike, does this change look OK?
Comment 7 User image PTO - Michael Ratcliffe [:miker] [:mratcliffe] 2013-09-23 07:06:32 PDT
Comment on attachment 807740 [details] [diff] [review]
Remove mentions of restarting in the options panel when toggling the remote and chrome debugging prefs

Review of attachment 807740 [details] [diff] [review]:
-----------------------------------------------------------------

Yup, looks good to me.
Comment 8 User image Panos Astithas [:past] 2013-09-24 01:19:50 PDT
https://hg.mozilla.org/integration/fx-team/rev/efab2edc6969
Comment 9 User image Ed Morley [:emorley] 2013-09-24 07:44:37 PDT
https://hg.mozilla.org/mozilla-central/rev/efab2edc6969

Note You need to log in before you can comment on or make changes to this bug.