Closed Bug 918329 Opened 7 years ago Closed 7 years ago

JavaScript Warning: "XUL box for toolbarbutton element contained an inline #text child, forcing all its children to be wrapped in a block." after bug 762761

Categories

(DevTools :: Debugger, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 27

People

(Reporter: vporof, Assigned: vporof)

Details

Attachments

(1 file)

This makes test output more noisy than it should be.
Thanks for filing, Victor. I didn't want to have to back out the last patch ;)
Dude, why would you backout for such a meaningless thing? Chill.
EVERYTHING MUST BE PERFECT ALL THE TIME, EVERYONE IS WATCHING
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Attachment #807672 - Flags: review?(nfitzgerald)
Comment on attachment 807672 [details] [diff] [review]
dbg-xul-warn.patch

Review of attachment 807672 [details] [diff] [review]:
-----------------------------------------------------------------

Not trying the patch out, because I've got a crazy rebase conflict going on, but I assume that you actually did tinker and verify that this does indeed look good. So this is just a review of the code, minimal as it is.

Anyways, thanks!
Attachment #807672 - Flags: review?(nfitzgerald) → review+
Thanks for the review. It looks the same.
https://hg.mozilla.org/mozilla-central/rev/a33fbf2dab5d
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 27
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.