918329 - JavaScript Warning: "XUL box for toolbarbutton element contained an inline #text child, forcing all its children to be wrapped in a block." after bug 762761

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Victor Porof [:vporof][:vp]]

This makes test output more noisy than it should be.

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Thanks for filing, Victor. I didn't want to have to back out the last patch ;)

Comment 2

[Victor Porof [:vporof][:vp]]

Dude, why would you backout for such a meaningless thing? Chill.

Comment 3

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

EVERYTHING MUST BE PERFECT ALL THE TIME, EVERYONE IS WATCHING

Comment 4

[Victor Porof [:vporof][:vp]]

Attachment: dbg-xul-warn.patch

Comment 5

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Comment on attachment 807672 [details] [diff] [review]
dbg-xul-warn.patch

Review of attachment 807672 [details] [diff] [review]:
-----------------------------------------------------------------

Not trying the patch out, because I've got a crazy rebase conflict going on, but I assume that you actually did tinker and verify that this does indeed look good. So this is just a review of the code, minimal as it is.

Anyways, thanks!

Comment 6

[Victor Porof [:vporof][:vp]]

Thanks for the review. It looks the same.

Comment 7

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/a33fbf2dab5d

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a33fbf2dab5d