Closed
Bug 918329
Opened 11 years ago
Closed 11 years ago
JavaScript Warning: "XUL box for toolbarbutton element contained an inline #text child, forcing all its children to be wrapped in a block." after bug 762761
Categories
(DevTools :: Debugger, defect)
DevTools
Debugger
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 27
People
(Reporter: vporof, Assigned: vporof)
Details
Attachments
(1 file)
3.07 KB,
patch
|
fitzgen
:
review+
|
Details | Diff | Splinter Review |
This makes test output more noisy than it should be.
Comment 1•11 years ago
|
||
Thanks for filing, Victor. I didn't want to have to back out the last patch ;)
Assignee | ||
Comment 2•11 years ago
|
||
Dude, why would you backout for such a meaningless thing? Chill.
Comment 3•11 years ago
|
||
EVERYTHING MUST BE PERFECT ALL THE TIME, EVERYONE IS WATCHING
Assignee | ||
Comment 4•11 years ago
|
||
Comment 5•11 years ago
|
||
Comment on attachment 807672 [details] [diff] [review] dbg-xul-warn.patch Review of attachment 807672 [details] [diff] [review]: ----------------------------------------------------------------- Not trying the patch out, because I've got a crazy rebase conflict going on, but I assume that you actually did tinker and verify that this does indeed look good. So this is just a review of the code, minimal as it is. Anyways, thanks!
Attachment #807672 -
Flags: review?(nfitzgerald) → review+
Assignee | ||
Comment 6•11 years ago
|
||
Thanks for the review. It looks the same.
Assignee | ||
Comment 7•11 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/a33fbf2dab5d
Whiteboard: [fixed-in-fx-team]
Comment 8•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a33fbf2dab5d
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 27
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•