918354 - [OS.File] Remove outer try/catch in osfile_async_worker.js

Status: RESOLVED FIXED

(Toolkit Graveyard :: OS.File, defect)

Description

[David Teller [:Yoric] - still alive but not very active]

Now that worker errors are displayed, we should get rid of the outer try/catch in osfile_async_worker.js.

Comment 1

[Errietta Kostala [:errietta]]

Attachment: Proposed patch

Comment 2

[David Teller [:Yoric] - still alive but not very active]

Comment on attachment 808522 [details] [diff] [review]
Proposed patch

Review of attachment 808522 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, but I'll wait until I have a version of this patch that ignores whitespace before finishing the review.
Also, you'll need to add ";r=yoric" at the end of your commit message.

::: toolkit/components/osfile/modules/osfile_async_worker.js
@@ +18,2 @@
>  
> +  /**

Nit: Could you keep the alignment of /** and the following * as it was before your patch?

@@ +94,2 @@
>  
> +  /**

Nit: Same thing her and in other uses of /**

Comment 3

[Errietta Kostala [:errietta]]

Attachment: Proposed patch

Comment 4

[Errietta Kostala [:errietta]]

Attachment: whitespace-insensitive patch (do not land)

Comment 5

[David Teller [:Yoric] - still alive but not very active]

Comment on attachment 808535 [details] [diff] [review]
whitespace-insensitive patch (do not land)

Review of attachment 808535 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.

Comment 6

[David Teller [:Yoric] - still alive but not very active]

Comment on attachment 808534 [details] [diff] [review]
Proposed patch

Review of attachment 808534 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. I forgot to ask you to add the bug# in the commit message. So, something like "Bug 918354 - Remove outer try/catch in osfile_async_worker.js; r=yoric"

Comment 7

[Errietta Kostala [:errietta]]

Attachment: Patch

Comment 8

[David Teller [:Yoric] - still alive but not very active]

Try: https://tbpl.mozilla.org/?tree=Try&rev=b9bc00760feb

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/5d4752319dd6

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5d4752319dd6