918362 - The "order" parameter passed to Bug.search is ignored

Status: RESOLVED FIXED

(Bugzilla :: WebService, defect)

Description

[David Lawrence [:dkl]]

Not sure how I missed this but here is the fix:

=== modified file 'Bugzilla/WebService/Bug.pm'
--- Bugzilla/WebService/Bug.pm	2013-09-18 15:08:32 +0000
+++ Bugzilla/WebService/Bug.pm	2013-09-19 15:45:02 +0000
@@ -504,7 +504,7 @@
         ThrowUserError('buglist_parameters_required');
     }
 
-    $options{order_columns} = [ split(/\s*,\s*/, delete $match_params{order}) ] if $match_params{order};
+    $options{order}  = [ split(/\s*,\s*/, delete $match_params{order}) ] if $match_params{order};
     $options{params} = \%match_params;
 
     my $search = new Bugzilla::Search(%options);


Will do a proper patch for hopefully quick review.

dkl

Comment 1

[David Lawrence [:dkl]]

Attachment: Patch to fix sorting in Bug.search (v1)

Comment 2

[Frédéric Buclin]

Comment on attachment 807233 [details] [diff] [review]
Patch to fix sorting in Bug.search (v1)

Despite this change is correct, it has no effect as you then call new_from_list() which always sorts the buglist by ID.

Comment 3

[David Lawrence [:dkl]]

Attachment: Patch to fix sorting in Bug.search (v2)

Comment 4

[Frédéric Buclin]

Comment on attachment 807329 [details] [diff] [review]
Patch to fix sorting in Bug.search (v2)

>+    # Bugzilla::Bug->new_from_list always sorts by bug id so we need to use a hash
>+    # to get the bugs back in the order requested by the client before converting
>+    # to bug hashes.

I honestly don't think this comment is useful. The trick used here is used "everywhere" now, for performance reasons. You can simply drop it, IMO. r=LpSolit

Comment 5

[David Lawrence [:dkl]]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk
modified Bugzilla/WebService/Bug.pm
Committed revision 8749.