Closed Bug 918375 Opened 8 years ago Closed 4 years ago

Remove Google Reader and add new services to region.properties as feed handler

Categories

(Mozilla Localizations :: zh-TW / Chinese (Traditional), defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla61

People

(Reporter: petercpg, Assigned: petercpg)

References

Details

(Keywords: productization)

Attachments

(1 file, 1 obsolete file)

Attached patch 9a3d9f7cf26f.patch (obsolete) — Splinter Review
We're removing Google, popping up Yahoo, and adding Netvibes, feedly, Aol Reader, InoReader after discussion in mailing list.

feedly won't be added to Fennec since it will redirect users to another landing page to download their app.

It's expected to land to aurora and central repo.
Attachment #807252 - Flags: review?(l10n)
Did you reach out to those services to get permission for including them in Firefox yet?
Nope. Are we required to do so?
Comment on attachment 807252 [details] [diff] [review]
9a3d9f7cf26f.patch

Review of attachment 807252 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, please.

Canceling review request until we have feedback.
Attachment #807252 - Flags: review?(l10n)
As my opinion, we should have someone from Mozilla to contact international service providers, rather than have each local communities do the same things. 

Filed bug 927299 for that.
Depends on: 927299
@Peter
Now that bug 927299 has been clarified, do you want to go ahead with this patch (I haven't checked if it still applies).

Note that AOL Reader should be removed, since it's shutting down
https://reader.aol.com/eos
Flags: needinfo?(petercpg)
Peter, any update here?
Thanks for pinging. 

Here's a new patch: 
* Adds Netvibes, Feedly, InoReader, The Old Reader
* Removes AOL Reader & Digg Reader
* All subscription URL are in https
* Unifies the name "My Yahoo!"
* Feedly: use new subscription link
Attachment #807252 - Attachment is obsolete: true
Flags: needinfo?(petercpg)
Attachment #8973500 - Flags: review?(francesco.lodolo)
Comment on attachment 8973500 [details] [diff] [review]
23bfd8061226.patch

Review of attachment 8973500 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Peter, it looks good.

For future patches:
* You should split out patches for SeaMonkey (and Thunderbird). I've CCed Ian, hopefully it's OK to land this with just my review.
* You should provide a fully formed patch (including author, commit message, etc.) instead of a diff, e.g.
https://mozilla-l10n.github.io/documentation/tools/mercurial/creating_mercurial_patch.html#creating-a-patch-using-queues
Attachment #8973500 - Flags: review?(francesco.lodolo) → review+
Landed in https://hg.mozilla.org/l10n-central/zh-TW/rev/880efe02eef2728631d48f88699e49d546b61671
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
this is landed in central and already work in nightly, does it means that we can expect it will go with train and be available in Firefox 62? (just want to track when will be there)
(In reply to Irvin (MozTW) from comment #10)
> this is landed in central and already work in nightly, does it means that we
> can expect it will go with train and be available in Firefox 62? (just want
> to track when will be there)

It will be already in 61.
(In reply to Francesco Lodolo [:flod] from comment #11)
> It will be already in 61.

great!
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.