918462 - Replace JS_IsConstructing() body with CallReceiver

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Steve Fink [:sfink] [:s:]]

I think I missed this in bug 890076.

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Replace JS_IsConstructing() body with CallReceiver

I *think* these are the same. Glad we have review.

Comment 2

[Jeff Walden [:Waldo]]

Comment on attachment 807366 [details] [diff] [review]
Replace JS_IsConstructing() body with CallReceiver

Review of attachment 807366 [details] [diff] [review]:
-----------------------------------------------------------------

Let's just remove JS_IsConstructing at this point.

Comment 3

[Steve Fink [:sfink] [:s:]]

Attachment: Replace JS_IsConstructing() body with CallReceiver

Works for me.

Comment 4

[Jeff Walden [:Waldo]]

Comment on attachment 807401 [details] [diff] [review]
Replace JS_IsConstructing() body with CallReceiver

Review of attachment 807401 [details] [diff] [review]:
-----------------------------------------------------------------

Please update the relevant bits of https://developer.mozilla.org/en-US/docs/SpiderMonkey/31 and https://developer.mozilla.org/en-US/docs/SpiderMonkey/JSAPI_Reference/JS_IsConstructing for this change.

::: js/src/jsapi-tests/testNewObject.cpp
@@ +21,2 @@
>  
>      JS::RootedObject obj(cx, JS_NewObjectForConstructor(cx, js::Jsvalify(&JSObject::class_), vp));

This can/should use JS_NewObject(cx, js::Jsvalify(&JSObject::class_), NULL, NULL) to get rid of the vp usage.

@@ +32,1 @@
>          JS_ReportError(cx, "test failed, argc == %d", argc);

Use args.length() here as well.

@@ +47,5 @@
>          return false;
>  
> +    args.rval().setObject(*obj);
> +
> +    // trash the argv, perversely

"You are not expected to understand this."?

@@ +50,5 @@
> +
> +    // trash the argv, perversely
> +    args[0].set(JSVAL_VOID);
> +    args[1].set(JSVAL_VOID);
> +    args[2].set(JSVAL_VOID);

Use setUndefined() for these.

Comment 5

[Steve Fink [:sfink] [:s:]]

Attachment: Replace JS_IsConstructing() body with CallReceiver,

Uploading the final version because I don't want to wait for the tree to reopen.

Comment 6

[Steve Fink [:sfink] [:s:]]

Comment on attachment 807515 [details] [diff] [review]
Replace JS_IsConstructing() body with CallReceiver,

Carry over the r+.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ad8143279d00

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ad8143279d00