918479 - Remove listeners from a message manager if the child side dies

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Fernando Jiménez Moreno [:ferjm]]

In order to do a proper clean up of message managers, we could add some kind of listener ID that the parent side could keep track of so when a child side dies the parent could remove the listeners added from that child.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

I'd be happy to implement this if someone proposes an easy to use API which doesn't break backwards compatibility. So, ideas are welcome.

Comment 2

[[:fabrice] Fabrice Desré]

So we are probably leaking in the parent when children are killed by the OOM killer? If so that's really bad and we need to fix this as soon as possible.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

So we do clear process message managers already.
Patch coming to do the same thing for frame message managers.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

https://tbpl.mozilla.org/?tree=Try&rev=a7916df4a129

Crossing fingers try looks ok. It should.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a2e78dec2ccf

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a2e78dec2ccf