918604 - Remove more enablePrivilege calls

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Martijn Wargers (dead)]

Attachment: enablepriv3.diff

This is another bunch of mochitest/chrome mochitests that are relatively easy to remove the enablePrivilege calls from.

There are some files that seem unused:
 dom/tests/mochitest/bugs/iframe_bug534362.html
 testing/mochitest/tests/test_bug362788.xhtml
 testing/mochitest/tests/test_bug366645.xhtml

No idea what to do with those. test_bug362788.xhtml can be made into a workable mochitest, but test_bug366645.xhtml doesn't work anymore.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 807547 [details] [diff] [review]
enablepriv3.diff

Review of attachment 807547 [details] [diff] [review]:
-----------------------------------------------------------------

thanks, this is a lot of great cleanup!

::: content/media/test/file_access_controls.html
@@ +123,5 @@
>    if (gVideo && gVideo.parentNode)
>      gVideo.parentNode.removeChild(gVideo);
>  
>    gVideo = null;
> +  SpecialPowers.forceGC();  

please remove the trailing whitespace here

::: dom/plugins/test/mochitest/cocoa_focus.html
@@ +92,5 @@
>        utils.sendNativeMouseEvent(plugin1X, plugin1Y, NSLeftMouseUp, 0, plugin1);
>        expectedEventCount++;
>  
>        // Blur the window.
> +      SpecialPowers.focus(opener);

focus on the opener or the window?

Comment 2

[Martijn Wargers (dead)]

(In reply to Joel Maher (:jmaher) from comment #1)
> >        // Blur the window.
> > +      SpecialPowers.focus(opener);
> 
> focus on the opener or the window?

Yes, this is a little weird, but there is no SpecialPowers way of blurring the window, so that's why I focused the opener window here, to blur the test window.
Anyway, I haven't been able to get this test working on my machine (with or without this patch), I get a weird error, I filed bug 918732 for that.
I'm going to see if this patch works on tryserver.

Comment 3

[Martijn Wargers (dead)]

Attachment: 918604.diff (git patch)

Comment 4

[Martijn Wargers (dead)]

Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=90808a5fc93c

Comment 5

[Martijn Wargers (dead)]

I'm still getting these failures on tryserver with dom/plugins/test/mochitest/test_cocoa_focus.html:
79 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/plugins/test/mochitest/test_cocoa_focus.html | Plugin should not have focus. - got true, expected false
80 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/plugins/test/mochitest/test_cocoa_focus.html | Focus event count should be 4 - got 3, expected 4
I wasn't able to exercise that test, because it always fails on my machine with some weird error, see bug 918732.
I tried to fix it blindly, but that turns out badly, so I'll leave it out my following patch.

On the b2g side, dom/tests/mochitest/dom-level0/test_innerWidthHeight_script.html and content/media/test/test_access_control.html are timing out, this is happening because the popup window doesn't have a SpecialPowers object installed. I filed bug 918842 for that.

Comment 6

[Martijn Wargers (dead)]

Attachment: 918604.diff

This is with the cocoa files removed, I'll file a new bug for that, to get that working. I left in test_innerWidthHeight_script.html and test_access_control.html.
Those tests should be working with the fix for bug 918842.

Comment 7

[Martijn Wargers (dead)]

(In reply to Martijn Wargers [:mwargers] (QA) from comment #6)
> This is with the cocoa files removed, I'll file a new bug for that, to get

I filed bug 920013 for it.

Comment 8

[Martijn Wargers (dead)]

Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=4d43dfa2164d

Comment 9

[Martijn Wargers (dead)]

Attachment: 918604.diff

Updated patch with what I mentioned in bug 918842, comment 8:
    SpecialPowers.pushPrefEnv({"set": [["dom.disable_window_move_resize", false]]}, runTest);
in test_innerWidthHeight_script.html

Comment 10

[Martijn Wargers (dead)]

Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=84f031582b74

Comment 11

[Martijn Wargers (dead)]

Comment on attachment 810014 [details] [diff] [review]
918604.diff

Review of attachment 810014 [details] [diff] [review]:
-----------------------------------------------------------------

Try server is green (this is with the patch for bug 918842 applied)

Comment 12

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 810014 [details] [diff] [review]
918604.diff

Review of attachment 810014 [details] [diff] [review]:
-----------------------------------------------------------------

looks great.

::: dom/tests/mochitest/general/test_clipboard_events.html
@@ +27,5 @@
>  // is used to make sure that leftover clipboard values from a previous
>  // test run don't cause a false-positive test.
>  var cb_text = "empty_" + Math.random();
>  setClipboardText(cb_text);
> +

nit: extra newline here.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/356ba083bb5f

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Backed out for frequent OSX timeouts in test_window_bar.html.
https://hg.mozilla.org/integration/mozilla-inbound/rev/9cc67deecdba

https://tbpl.mozilla.org/php/getParsedLog.php?id=28486539&tree=Mozilla-Inbound

Comment 15

[Ryan VanderMeulen [:RyanVM]]

That was a red herring. Re-landed, and sorry for the churn :(
https://hg.mozilla.org/integration/mozilla-inbound/rev/e1914e294152

Comment 16

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e1914e294152