918611 - packaged app on Fennec fails in nsIAppsService::getAppInfo with "unsupported apps platform"

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Web Apps (PWAs), defect)

Description

[Myk Melez [:myk] [@mykmelez]]

Attachment: 0001-define-MOZ_FENNEC-for-preprocessor.patch

Bug 917310 broke running packaged apps on Fennec, which fails with:

E/GeckoConsole(13632): [JavaScript Error: "[Exception... "'Error: Unsupported apps platform' when calling method: [nsIAppsService::getAppInfo]"  nsresult: "0x8057001c (NS_ERROR_XPC_JS_THREW_JS_OBJECT)"  location: "JS frame :: jar:jar:file:///data/app/org.mozilla.fennec_myk-1.apk!/assets/omni.ja!/components/AppProtocolHandler.js :: app_phGetAppInfo :: line 40"  data: no]" {file: "jar:jar:file:///data/app/org.mozilla.fennec_myk-1.apk!/assets/omni.ja!/components/AppProtocolHandler.js" line: 40}]

The problem is that MOZ_FENNEC, which I added to mobile/android/confvars.sh in bug 797613, isn't defined when the preprocessor processes toolkit/webapps/WebappOSUtils.jsm, which uses MOZ_FENNEC to determine the implementation of getInstallPath.

I'm not a build expert, but the fix appears to be to AC_DEFINE(MOZ_FENNEC) in configure.in.  The relevant part of configure.in says to use MOZ_BUILD_APP instead, but config/Preprocessor.py is too primitive to use MOZ_BUILD_APP in this case, since the value of that variable is "mobile/android" for Fennec, which contains a slash character, and Preprocessor.py can only compare MOZ_BUILD_APP to a string of letters (\w+).

Comment 1

[Mike Hommey [:glandium]]

Comment on attachment 807551 [details] [diff] [review]
0001-define-MOZ_FENNEC-for-preprocessor.patch

Review of attachment 807551 [details] [diff] [review]:
-----------------------------------------------------------------

Considering toolkit/webapps/WebappOSUtils.jsm is the only file using MOZ_FENNEC, I'd rather see the define added in toolkit/webapps, based on MOZ_BUILD_APP. (and you can remove MOZ_FENNEC from confvars.sh, while you're here)

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Attachment: 0001-define-MOZ_FENNEC-when-building-mobile-android.patch

Comment 3

[Myk Melez [:myk] [@mykmelez]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d5de24a40c49

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d5de24a40c49