91871 - Launch File & Reveal Location don't work

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect, P1)

Description

[Adam]

Mozilla 0.9.2 2001071805, Mac OS X 10.0.4:

1) Download something
2) Make sure the "Keep window open..." option is checked
3) When the download completes, click the launch file and/or reveal location buttons

Nothing happens. The reveal location button switches to the Finder, but no
window is opened. The launch file button just does nothing.

The reveal location button should make the Finder active and open the download
location window and the launch file button should open the file.

Comment 1

[sairuh (rarely reading bugmail)]

sounds like the Mac OS X analog to bug 67001. mscott, should this be yours? punt
as needed...

Comment 2

[Scott MacGregor]

sounds like OS X specific problems. Launch & reveal work on my imac run system
8.5 ( i think i'm 8.5).

Both launch & reveal are implemented in nsLocalFileMac.cpp. 

Who are our OS X fellows?

Comment 3

[sairuh (rarely reading bugmail)]

tentatively nominating.

should this go to sdagley?

interestingly, these buttons also don't work in linux [bug 67001].

however, on os x clicking Reveal Location does something by bringing the Finder
to the foreground [testing with 2001.09.04.08-comm bits] --but it doesn't open
the target folder. and the Launch File button [still] does nothing.

Comment 4

[Simon Fraser [no longer active]]

We need some Launch Services loving here. That crufty old apple event stuff won't 
work on X.

Comment 5

[Steve Dagley]

Not quite a dupe of 97676 but related so setting priority level to match

Comment 6

[Jaime Rodriguez, Jr.]

This is not on Tian Tian Must Fix list for this release. Should we onsider
minusing it.

Comment 7

[Steve Dagley]

97676 is on the list.  This bug is related so it stays.

Comment 8

[lchiang]

Once 97676 gets fixed, then this bug will get fixed automatically?

Comment 9

[Steve Dagley]

to answer lchaing's question regarding 97676 fixing this bug - yes.  Actually the 
Launch and Reveal code is working now, it's just the automatic helper app code 
that's currently causing me grief and why 97676 isn't fixed yet

Comment 10

[Steve Dagley]

Going ahead and closing as a dupe of 97676 (and I don't recall why I didn't do that in the first place)Ê

*** This bug has been marked as a duplicate of 97676 ***

Comment 11

[sairuh (rarely reading bugmail)]

here is what i saw, testing 2001.10.02.04-branch comm bits on 10.0.4:

A. OS-defined helper app [.bin file], carbonized version of StuffIt Expander 
[already] selected:

1. Reveal Location opened a Finder window, displaying the folder in which the
file [with the garbled filename] was downloaded.
2. Launch File launched StuffIt Expander again.


B. user-defined helper app, via Choose button [.exe file], selected the
carbonized version of BBEdit Lite:
1. Reveal Location opened a Finder window, displaying the folder in which the
file [again with the garbled filename] was downloaded.
2. Launch File, however, just launched the Classic Environment...and no other
application.


so, results from A1, A2 and B2 all sound like expected behavior.

i'm reopening this because:
* i want to verify/test this separately from bug 97676.
* the behavior in B2 seems buggy to me. :)

pls let me know what to expect for B2, eg, if that's covered by another bug
[which it might be]. thx!

Comment 12

[Steve Dagley]

Actually the B2 behavior is correct (or at least matches the non-OS X behavior).  
Rather than launching the helper app with the DL'd doc, Launch is equivalent to 
double-clicking a document in the Finder.  In the case of a .exe file I don't 
think there is any mapping for the OS (interesting that it'd launch the Classic 
Environment though).  Try the test with a .sit or .zip file you've directed to a 
different helper app and then verify Launch opens the file w/StuffIt Expander.

Comment 13

[sairuh (rarely reading bugmail)]

thx for the clarification, steve!

so, testing with 2001.10.08.04-0.9.4 [branch] comm bits on 10.1:

1. Reveal Location still works :)

2. i clicked on a .zip file and specifically chose the classic version of
StuffIt Expander to open it, which did launch after download was complete
(yes!). after that, though, i clicked on the Launch File anyhow, to see what
would happen: the *carbonized* version of StuffIt Expander launches. this sounds
reasonable/correct behavior to me...

sound good?

Comment 14

[sairuh (rarely reading bugmail)]

vrfy fixed on 10.1 using 2001.10.22.13-trunk comm bits, using tests in my last
comment above.