918875 - Correlations on report list fails if report list has no OSes

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[Peter Bengtsson [:peterbe]]

Example error: 
https://errormill.mozilla.org/webtools/socorro-prod/group/108885/

Happens on 
https://crash-stats.mozilla.com/report/list/partials/correlations/?product=Firefox&range_value=7&range_unit=days&date=2013-09-20&signature=EMPTY%3A+no+crashing+thread+identified%3B+corrupt+dump&version=Firefox%3A25.0b

Comment 1

[Robert Helmer [:rhelmer]]

Hmm so correlation reports do have "None" as an OS option, we're probably not picking it up (I don't think it's really all that useful): https://crash-analysis.mozilla.com/crash_analysis/20130920/20130920_Firefox_23.0.1-core-counts.txt.gz

However we should be catching this exception somewhere regardless...

Comment 2

[Peter Bengtsson [:peterbe]]

(In reply to Robert Helmer [:rhelmer] from comment #1)
> Hmm so correlation reports do have "None" as an OS option, we're probably
> not picking it up (I don't think it's really all that useful):
> https://crash-analysis.mozilla.com/crash_analysis/20130920/
> 20130920_Firefox_23.0.1-core-counts.txt.gz
> 

That's not really what happens. We also take care of it when the only os found is `None`. What happened in this bug is that the there were basically nothing in the ReportList. So os_counts.keys() became `[]`.

Comment 3

[Peter Bengtsson [:peterbe]]

PR: https://github.com/mozilla/socorro/pull/1532

Comment 4

[Peter Bengtsson [:peterbe]]

Steps to reproduce:

1. For any of the featured Firefox versions, open their Top Crasher page
2. Click the `EMPTY: no crashing thread identified; corrupt dump` signature
3. Click the "Correlations" tab 

Expected output:

  No OS for all reports under this signature.

Actual output:

  Unable to load correlations. Please try again later.  
(in red, meaning 500 error on the XHR)

Comment 5

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/17ab6ffd75c44fc34c086c170d280692c5226736
fixes bug 918875 - Correlations on report list fails if report list has no OSes, r=rhelmer

Comment 6

[Matt Brandt [:mbrandt]]

Attachment: qa - reopened

Reopening for more information:

This appears to already be on prod, I see the "No OS for all reports under this signature."

https://crash-stats.mozilla.com/report/list?product=Firefox&range_value=7&range_unit=days&date=2013-09-25&signature=EMPTY%3A+no+crashing+thread+identified%3B+corrupt+dump&version=Firefox%3A27.0a1

Comment 7

[Peter Bengtsson [:peterbe]]

Thanks for looking in to this. 
The same output is used for two different scenarios:

1. The only OS in the reports is None
2. There are no reports at all

Our code used to check if it was None and if so, return that message ("No OS for all reports under this signature."). However, I found that sometimes there is nothing to compare to so we got an error. Ie. it was even worse than the only OS being None. 
But to the end user they don't really care, so I re-used the exact same error as for the the OS was None. 

Hope that helps.

Comment 8

[Matt Brandt [:mbrandt]]

Attachment: qa - verified on stage

Many thanks peterbe - that is much clearer to me. Also thank you for explaining that the url in comment 0 is a partial that only returns the ajax response that is integrated into the UI.

Correlation report shows the expected error message on stage:

https://crash-stats.allizom.org/report/list/partials/correlations/?product=Firefox&range_value=7&range_unit=days&date=2013-09-20&signature=EMPTY%3A+no+crashing+thread+identified%3B+corrupt+dump&version=Firefox%3A25.0b

Example of bug on prod:

https://crash-stats.mozilla.com/report/list?product=Firefox&range_value=7&range_unit=days&date=2013-09-26&signature=EMPTY%3A+no+crashing+thread+identified%3B+corrupt+dump&version=Firefox%3A25.0b