918934 - Update jit-tests remote harness

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Dan Minor [:dminor]]

I need to make some changes to how the jit-tests are packaged so that relative paths in the JavaScript include paths work as expected. This in turn requires some small changes to paths in the remote test harness.

Comment 1

[Dan Minor [:dminor]]

Attachment: Patch to add ecma_6 and change directory structure on remote device.

Try run here: https://tbpl.mozilla.org/?tree=Try&rev=1f58ae747f29

I've added the ecma_6 directory and I've changed the directory structure on the remote device. We used to flatten the hierarchy in a way that breaks relative paths, so I've made things match the local hierarchy.

Comment 2

[Terrence Cole [:terrence]]

Comment on attachment 808526 [details] [diff] [review]
Patch to add ecma_6 and change directory structure on remote device.

Review of attachment 808526 [details] [diff] [review]:
-----------------------------------------------------------------

The path changes look good. We probably should have set it up like that in the first place. One question however:

::: js/src/tests/lib/jittests.py
@@ +27,5 @@
>  JS_DIR = os.path.dirname(os.path.dirname(TESTS_LIB_DIR))
>  TOP_SRC_DIR = os.path.dirname(os.path.dirname(JS_DIR))
>  TEST_DIR = os.path.join(JS_DIR, 'jit-test', 'tests')
>  LIB_DIR = os.path.join(JS_DIR, 'jit-test', 'lib') + os.path.sep
> +ECMA6_DIR = posixpath.join(JS_DIR, 'tests', 'ecma_6')

Can you explain why jittests needs to know about this directory at all? This would seem to be a random directory for a different test harness and jittests really should not be depending on it.

Comment 3

[Terrence Cole [:terrence]]

Comment on attachment 808526 [details] [diff] [review]
Patch to add ecma_6 and change directory structure on remote device.

Review of attachment 808526 [details] [diff] [review]:
-----------------------------------------------------------------

The path changes look good. We probably should have set it up like that in the first place. One question however:

::: js/src/tests/lib/jittests.py
@@ +27,5 @@
>  JS_DIR = os.path.dirname(os.path.dirname(TESTS_LIB_DIR))
>  TOP_SRC_DIR = os.path.dirname(os.path.dirname(JS_DIR))
>  TEST_DIR = os.path.join(JS_DIR, 'jit-test', 'tests')
>  LIB_DIR = os.path.join(JS_DIR, 'jit-test', 'lib') + os.path.sep
> +ECMA6_DIR = posixpath.join(JS_DIR, 'tests', 'ecma_6')

Can you explain why jittests needs to know about this directory at all? This would seem to be a random directory for a different test harness and jittests really should not be depending on it.

Comment 4

[Terrence Cole [:terrence]]

After discussion on IRC, #jsapi decided this is gross, but better than duplicating the shared code.

Comment 5

[Dan Minor [:dminor]]

Thanks for the review.

https://hg.mozilla.org/integration/mozilla-inbound/rev/d7b910c458af

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d7b910c458af