Closed Bug 918994 Opened 6 years ago Closed 6 years ago

"ASSERTION: Can't sticky position individual continuations" with rtl, wrapping

Categories

(Core :: Layout: Positioned, defect)

x86_64
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla27

People

(Reporter: jruderman, Assigned: dbaron)

References

(Blocks 1 open bug)

Details

(Keywords: assertion, testcase)

Attachments

(2 files)

Attached file testcase
###!!! ASSERTION: Can't sticky position individual continuations: '!aFrame->GetPrevContinuation()', file layout/generic/StickyScrollContainer.cpp, line 133
Attached file layer tree and stack
We're reaching this via StickyScrollContainer::ComputeScrollRanges (from bug 897105).

I guess I hadn't considered how those two should interact. Ideally, I suppose we only need one layer per sticky element, not per sticky frame. But even with a layer per frame, the ScrollRanges are relative, so should be identical for each frame's layer. So we might be able to just move that assertion from ComputeStickyLimits into ComputePosition?
But it's computing incorrect results because GetAllInFlowRectsUnion actually only looks forward and not backward.

I'll probably fix this in bug 828312 patch 9a, though.
This testcase no longer asserts on mozilla-central.  I guess it was fixed in bug 828312.
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Assignee: nobody → dbaron
Depends on: 828312
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.