Closed
Bug 919072
Opened 12 years ago
Closed 11 years ago
Intermittent TEST-UNEXPECTED-FAIL | browser_webconsole_bug_601352_scroll.js | scroll location is not at the top - Didn't expect 0, but got it
Categories
(DevTools :: Console, defect)
Tracking
(firefox27 fixed, firefox28 fixed, firefox29 fixed, firefox-esr24 unaffected, b2g-v1.2 fixed)
RESOLVED
FIXED
Firefox 29
| Tracking | Status | |
|---|---|---|
| firefox27 | --- | fixed |
| firefox28 | --- | fixed |
| firefox29 | --- | fixed |
| firefox-esr24 | --- | unaffected |
| b2g-v1.2 | --- | fixed |
People
(Reporter: KWierso, Assigned: msucan)
Details
(Keywords: intermittent-failure)
Attachments
(2 files)
|
1.60 KB,
patch
|
Details | Diff | Splinter Review | |
|
4.48 KB,
patch
|
Details | Diff | Splinter Review |
https://tbpl.mozilla.org/php/getParsedLog.php?id=28162248&tree=Mozilla-Inbound
slave: t-w864-ix-081
10:45:39 INFO - TEST-START | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_webconsole_bug_601352_scroll.js
10:45:39 WARNING - TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_webconsole_bug_601352_scroll.js | scroll location is not at the top - Didn't expect 0, but got it
10:45:39 INFO - Stack trace:
10:45:39 INFO - JS frame :: chrome://mochikit/content/browser-test.js :: test_isnot :: line 629
10:45:39 INFO - JS frame :: chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_webconsole_bug_601352_scroll.js :: performTest :: line 33
10:45:39 INFO - JS frame :: resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/webconsole/webconsole.js :: <TOP_LEVEL> :: line 3111
10:45:39 INFO - JS frame :: resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/webconsole/webconsole.js :: WCF__flushMessageQueue :: line 2035
10:45:39 INFO - native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0
Followed by
10:45:39 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_webconsole_bug_601352_scroll.js | output height 164 node top 56 node bottom 78 node height 22
10:45:39 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_webconsole_bug_601352_scroll.js | last message is visible
10:45:39 INFO - console.error:
10:45:39 INFO - Message: TypeError: null has no properties
10:45:39 INFO - Stack:
10:45:39 INFO - @resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/webconsole/webconsole.js:3117
10:45:39 INFO - WCF__flushMessageQueue@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/webconsole/webconsole.js:2035
10:45:39 INFO - INFO TEST-END | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_webconsole_bug_601352_scroll.js | finished in 534ms
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Assignee | ||
Comment 18•12 years ago
|
||
Attempt to fix this intermittent failure. Sometimes the scrollTop value is not updated soon enough for the test. This patch tries to force a reflow before checking scrollTop.
r=me
Landed: https://hg.mozilla.org/integration/fx-team/rev/647072336c9e
Assignee: nobody → mihai.sucan
Status: NEW → ASSIGNED
| Assignee | ||
Updated•12 years ago
|
Whiteboard: [fixed-in-fx-team]
Comment 19•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 29
Comment 20•12 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/9c59eb7fb40c
https://hg.mozilla.org/releases/mozilla-beta/rev/8e90d365bd12
https://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/d48bfe9f5af7
status-b2g-v1.2:
--- → fixed
status-firefox27:
--- → fixed
status-firefox28:
--- → fixed
status-firefox29:
--- → fixed
status-firefox-esr24:
--- → unaffected
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Reporter | ||
Updated•11 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Assignee | ||
Comment 24•11 years ago
|
||
Did more investigation for this test failure. Identified two problems:
- the test doesnt wait for all messages to be displayed in the output. the test assumes that the eval output will be after the console.log() calls, which is not always true.
- how the test checks if the last message is visible is not accurate.
Updated the test to fix both issues, and rewrote it using Task.spawn().
Green try run: https://tbpl.mozilla.org/?tree=Try&rev=004275fdaf61
r=me
Landed: https://hg.mozilla.org/integration/fx-team/rev/d2f51fa6a16d
| Assignee | ||
Updated•11 years ago
|
Whiteboard: [fixed-in-fx-team]
Comment 25•11 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 12 years ago → 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•