Intermittent TEST-UNEXPECTED-FAIL | browser_webconsole_bug_601352_scroll.js | scroll location is not at the top - Didn't expect 0, but got it

RESOLVED FIXED in Firefox 27, Firefox OS v1.2

Status

DevTools
Console
RESOLVED FIXED
5 years ago
9 days ago

People

(Reporter: KWierso, Assigned: msucan)

Tracking

({intermittent-failure})

Trunk
Firefox 29
All
Windows 8
intermittent-failure
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox27 fixed, firefox28 fixed, firefox29 fixed, firefox-esr24 unaffected, b2g-v1.2 fixed)

Details

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
https://tbpl.mozilla.org/php/getParsedLog.php?id=28162248&tree=Mozilla-Inbound
slave: t-w864-ix-081



10:45:39     INFO -  TEST-START | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_webconsole_bug_601352_scroll.js
10:45:39  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_webconsole_bug_601352_scroll.js | scroll location is not at the top - Didn't expect 0, but got it
10:45:39     INFO -  Stack trace:
10:45:39     INFO -      JS frame :: chrome://mochikit/content/browser-test.js :: test_isnot :: line 629
10:45:39     INFO -      JS frame :: chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_webconsole_bug_601352_scroll.js :: performTest :: line 33
10:45:39     INFO -      JS frame :: resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/webconsole/webconsole.js :: <TOP_LEVEL> :: line 3111
10:45:39     INFO -      JS frame :: resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/webconsole/webconsole.js :: WCF__flushMessageQueue :: line 2035
10:45:39     INFO -      native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0


Followed by 
10:45:39     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_webconsole_bug_601352_scroll.js | output height 164 node top 56 node bottom 78 node height 22
10:45:39     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_webconsole_bug_601352_scroll.js | last message is visible
10:45:39     INFO -  console.error:
10:45:39     INFO -    Message: TypeError: null has no properties
10:45:39     INFO -    Stack:
10:45:39     INFO -      @resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/webconsole/webconsole.js:3117
10:45:39     INFO -  WCF__flushMessageQueue@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/webconsole/webconsole.js:2035
10:45:39     INFO -  INFO TEST-END | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_webconsole_bug_601352_scroll.js | finished in 534ms
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
(Assignee)

Comment 18

5 years ago
Created attachment 8361005 [details] [diff] [review]
bug919072-1.diff

Attempt to fix this intermittent failure. Sometimes the scrollTop value is not updated soon enough for the test. This patch tries to force a reflow before checking scrollTop.

r=me

Landed: https://hg.mozilla.org/integration/fx-team/rev/647072336c9e
Assignee: nobody → mihai.sucan
Status: NEW → ASSIGNED
(Assignee)

Updated

5 years ago
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/647072336c9e
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 29
https://hg.mozilla.org/releases/mozilla-aurora/rev/9c59eb7fb40c
https://hg.mozilla.org/releases/mozilla-beta/rev/8e90d365bd12
https://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/d48bfe9f5af7
status-b2g-v1.2: --- → fixed
status-firefox27: --- → fixed
status-firefox28: --- → fixed
status-firefox29: --- → fixed
status-firefox-esr24: --- → unaffected
Comment hidden (Treeherder Robot)
(Reporter)

Updated

5 years ago
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
(Assignee)

Comment 24

4 years ago
Created attachment 8374387 [details] [diff] [review]
bug919072-2.diff

Did more investigation for this test failure. Identified two problems:

- the test doesnt wait for all messages to be displayed in the output. the test assumes that the eval output will be after the console.log() calls, which is not always true.

- how the test checks if the last message is visible is not accurate.


Updated the test to fix both issues, and rewrote it using Task.spawn().

Green try run: https://tbpl.mozilla.org/?tree=Try&rev=004275fdaf61


r=me

Landed: https://hg.mozilla.org/integration/fx-team/rev/d2f51fa6a16d
(Assignee)

Updated

4 years ago
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/d2f51fa6a16d
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago4 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]

Updated

9 days ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.