Closed Bug 919087 Opened 11 years ago Closed 11 years ago

Intermittent TEST-UNEXPECTED-FAIL | test_cache2-22-anon-visit.js | test failed (with xpcshell return code: 0), see following log | head_cache2.js | 1 == 0 - See following stack

Categories

(Core :: Networking: Cache, defect)

All
Android
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla27
Tracking Status
firefox25 --- unaffected
firefox26 --- unaffected
firefox27 --- fixed
firefox-esr24 --- unaffected

People

(Reporter: KWierso, Assigned: mayhemer)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

https://tbpl.mozilla.org/php/getParsedLog.php?id=28175889&tree=Mozilla-Inbound#error0
using slave: tegra-107

These files were introduced in bug 913807. Unsure if you want to look into this or just disable it on android for being flaky, Honza.

TEST-UNEXPECTED-FAIL | /builds/tegra-107/test/build/tests/xpcshell/tests/netwerk/test/unit/test_cache2-22-anon-visit.js | test failed (with xpcshell return code: 0), see following log:
>>>>>>>
xpcw: cd /mnt/sdcard/tests/xpcshell/netwerk/test/unit
xpcw: xpcshell -r /mnt/sdcard/tests/xpcshell/c/httpd.manifest --greomni /data/local/xpcb/fennec-27.0a1.en-US.android-arm.apk -m -n -s -e const _HTTPD_JS_PATH = "/mnt/sdcard/tests/xpcshell/c/httpd.js"; -e const _HEAD_JS_PATH = "/mnt/sdcard/tests/xpcshell/head.js"; -e const _TESTING_MODULES_DIR = "/mnt/sdcard/tests/xpcshell/m"; -f /mnt/sdcard/tests/xpcshell/head.js -e const _SERVER_ADDR = "localhost" -e const _HEAD_FILES = ["/mnt/sdcard/tests/xpcshell/netwerk/test/unit/head_channels.js", "/mnt/sdcard/tests/xpcshell/netwerk/test/unit/head_cache.js", "/mnt/sdcard/tests/xpcshell/netwerk/test/unit/head_cache2.js"]; -e const _TAIL_FILES = []; -e const _TEST_FILE = ["test_cache2-22-anon-visit.js"]; -e _execute_test(); quit(0);
TEST-INFO | (xpcshell/head.js) | test MAIN run_test pending (1)
TEST-INFO | (xpcshell/head.js) | test pending (2)
TEST-INFO | (xpcshell/head.js) | test MAIN run_test finished (2)
TEST-INFO | (xpcshell/head.js) | running event loop
TEST-INFO | CACHE2: callback #1(an2) onCacheEntryAvailable, 257
TEST-PASS | /mnt/sdcard/tests/xpcshell/netwerk/test/unit/head_cache2.js | [OpenCallback.prototype.onCacheEntryAvailable : 130] true == true
TEST-PASS | /mnt/sdcard/tests/xpcshell/netwerk/test/unit/head_cache2.js | [OpenCallback.prototype.onCacheEntryAvailable : 133] true == true
TEST-PASS | /mnt/sdcard/tests/xpcshell/netwerk/test/unit/head_cache2.js | [OpenCallback.prototype.onCacheEntryAvailable : 143] true == true
TEST-INFO | (xpcshell/head.js) | test pending (2)
TEST-INFO | CACHE2: callback #2(an2) onCacheEntryAvailable, 257
TEST-PASS | /mnt/sdcard/tests/xpcshell/netwerk/test/unit/head_cache2.js | [OpenCallback.prototype.onCacheEntryAvailable : 130] true == true
TEST-PASS | /mnt/sdcard/tests/xpcshell/netwerk/test/unit/head_cache2.js | [OpenCallback.prototype.onCacheEntryAvailable : 133] true == true
TEST-PASS | /mnt/sdcard/tests/xpcshell/netwerk/test/unit/head_cache2.js | [OpenCallback.prototype.onCacheEntryAvailable : 143] true == true
TEST-INFO | (xpcshell/head.js) | test pending (3)
TEST-INFO | (xpcshell/head.js) | test pending (4)
TEST-INFO | (xpcshell/head.js) | test finished (4)
TEST-INFO | (xpcshell/head.js) | test pending (4)
TEST-INFO | (xpcshell/head.js) | test finished (4)
TEST-INFO | CACHE2: callback #1(an2) openOutputStream @ 0
TEST-INFO | CACHE2: callback #1(an2) writing data
TEST-PASS | /mnt/sdcard/tests/xpcshell/netwerk/test/unit/head_cache2.js | [OpenCallback.prototype.onCacheEntryAvailable/</< : 194] 3 == 3
TEST-INFO | (xpcshell/head.js) | test finished (3)
TEST-INFO | CACHE2: callback #2(an2) openOutputStream @ 0
TEST-INFO | CACHE2: callback #2(an2) writing data
TEST-PASS | /mnt/sdcard/tests/xpcshell/netwerk/test/unit/head_cache2.js | [OpenCallback.prototype.onCacheEntryAvailable/</< : 194] 3 == 3
TEST-INFO | (xpcshell/head.js) | test finished (2)
TEST-PASS | /mnt/sdcard/tests/xpcshell/netwerk/test/unit/head_cache.js | [syncWithCacheIOThread/< : 107] 2152398909 == 2152398909
TEST-INFO | CACHE2: callback #3(---) onCacheStorageInfo: num=2, size=3072
TEST-PASS | /mnt/sdcard/tests/xpcshell/netwerk/test/unit/head_cache2.js | [VisitCallback.prototype.onCacheStorageInfo : 269] 2 == 2
TEST-INFO | CACHE2: callback #3(---) onCacheEntryInfo: key=http://an2/
TEST-PASS | /mnt/sdcard/tests/xpcshell/netwerk/test/unit/head_cache2.js | [VisitCallback.prototype.onCacheEntryInfo : 282] true == true
TEST-PASS | /mnt/sdcard/tests/xpcshell/netwerk/test/unit/head_cache2.js | [VisitCallback.prototype.onCacheEntryInfo : 285] true == true
TEST-INFO | CACHE2: callback #3(---) onCacheEntryVisitCompleted
TEST-UNEXPECTED-FAIL | /mnt/sdcard/tests/xpcshell/netwerk/test/unit/head_cache2.js | 1 == 0 - See following stack:
JS frame :: /mnt/sdcard/tests/xpcshell/netwerk/test/unit/head_cache2.js :: VisitCallback.prototype.onCacheEntryVisitCompleted :: line 293
JS frame :: test_cache2-22-anon-visit.js :: run_test/checkOldBackEnd/< :: line 38
JS frame :: /mnt/sdcard/tests/xpcshell/netwerk/test/unit/head_cache.js :: syncWithCacheIOThread/< :: line 108
JS frame :: /mnt/sdcard/tests/xpcshell/netwerk/test/unit/head_cache.js :: asyncOpenCacheEntry/CacheListener.prototype.onCacheEntryAvailable :: line 85
native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0
TEST-INFO | (xpcshell/head.js) | exiting test

<<<<<<<
Flags: needinfo?(honzab.moz)
I think disable it on Android.  I'll take a look and establish some theory why this test fails and then we may reintroduce it or at least know the cause.
Flags: needinfo?(honzab.moz)
Tho, I'll get to this on Monday.
Assignee: nobody → honzab.moz
I think I have it.  We must close all cache entries before we do visit checks.  Active (open) entries are not visited by the old cache back end, a nice 'feature'.

I'll have a patch soon.
Status: NEW → ASSIGNED
Attached patch v1Splinter Review
- when old back-end is used, delay fire of MultipleCallbacks target callback (go through do_execute_soon instead of a direct call)
- this makes entry.close() at [1] be called before cacheService.visit()

[1] http://hg.mozilla.org/mozilla-central/annotate/1fda74e33e06/netwerk/test/unit/head_cache2.js#l199
Attachment #809211 - Flags: review?(michal.novotny)
No longer depends on: 913807
Attachment #809211 - Flags: review?(michal.novotny) → review+
https://hg.mozilla.org/mozilla-central/rev/523b572e9987
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: