919155 - After editing a source, it takes multiple page refreshes for the text contents to get updated in the debugger

Status: VERIFIED FIXED

(DevTools :: Debugger, defect, P1)

Description

[Victor Porof [:vporof][:vp]]

More precisely, it takes 2 refreshes.

This is because we're clearing the cache too late, on the target's "navigate" notification. However, newScript events can be fired in between "will-navigate" and "navigate" as well, in which case it takes another refresh to actually refetch the source's text.

Comment 1

[Victor Porof [:vporof][:vp]]

Attachment: dbg-discard-sources.patch

Comment 2

[Victor Porof [:vporof][:vp]]

Try was green: https://tbpl.mozilla.org/?tree=Try&rev=88b14648c12c

Comment 3

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 808155 [details] [diff] [review]
dbg-discard-sources.patch

Review of attachment 808155 [details] [diff] [review]:
-----------------------------------------------------------------

you bet.

Comment 4

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/e4428c901e4c

Comment 5

[Victor Porof [:vporof][:vp]]

Comment on attachment 808155 [details] [diff] [review]
dbg-discard-sources.patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Caching sources too long while reloading.
User impact if declined: Developers using the debugger will usually need to reload their app twice before being able to inspect the new sources.
Testing completed (on m-c, etc.): locally, fx-team
Risk to taking this patch (and alternatives if risky): None
String or IDL/UUID changes made by this patch: None

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/e4428c901e4c

Comment 7

[Ryan VanderMeulen [:RyanVM]]

This has conflicts due to bug 800857 not being on Aurora. Please attach a branch-specific patch or request approval for that as well.

Comment 8

[Victor Porof [:vporof][:vp]]

Will do.

Comment 9

[Victor Porof [:vporof][:vp]]

Rebased try on aurora: https://tbpl.mozilla.org/?tree=Try&rev=c7dbc529d493

Comment 10

[Victor Porof [:vporof][:vp]]

Attachment: dbg-discard-sources.patch rebased for aurora

Comment 11

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/0dd4f8f0c703

Comment 12

[Catalin Varga [QA][:VarCat]]

Verified as fixed on FF 26.0b2:

Build Id: 20131104182142
Build identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0

OS:Windows 7 x64
Ubuntu:10.8 x32
Mac Os X: 10.8.4

Comment 13

[Catalin Varga [QA][:VarCat]]

Verified as fixed on FF 27.0b2:

Build Id: 20131105004004
Build identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:27.0) Gecko/20100101 Firefox/27.0

OS:
Windows 7 x64
Ubuntu:12.04 x32
Mac Os X: 10.8.4