919177 - Enable user subdomains by default

Status: RESOLVED FIXED

(Webmaker Graveyard :: General, defect)

Description

[Pomax]

filed under make-valet since it's responsible for userdomain serving - we might be able to do something clever with https://github.com/iriscouch/dnsd to effect a local DNS when running everything on localhost, so that we (and contributors) don't need to do any hosts fiddling

Comment 1

[Jon Buckley [:jbuck]]

https://github.com/JamesHight/node-evil-dns looks like it might be exactly what we want. Even supports wildcard domains!

Comment 2

[Jon Buckley [:jbuck]]

We should:

1) Register some domain, say webmaker-dev.org
2) Set it up at Route53 with wildcard subdomains
3) Default user subdomains in each of our apps to this domain

Then we can tackle removing the embed shells from Thimble and Popcorn.

Comment 3

[Jon Buckley [:jbuck]]

xip.io is a free wildcard DNS service. Now we can do this!

Comment 4

[Jon Buckley [:jbuck]]

Attachment: https://github.com/mozilla/make-valet/pull/42

Comment 5

[Jon Buckley [:jbuck]]

Attachment: https://github.com/mozilla/goggles.webmaker.org/pull/89

This relies on the makevalet patch to be applied before using this patch.

Comment 6

[Jon Buckley [:jbuck]]

Attachment: https://github.com/mozilla/popcorn.webmaker.org/pull/414

This relies on the makevalet patch to be applied

Comment 7

[Jon Buckley [:jbuck]]

Attachment: https://github.com/mozilla/thimble.webmaker.org/pull/342

This relies on the make-valet patch to be applied

Comment 8

[Pomax]

I'm still missing something here that describes what needs to be done to run this true localhost. Documenting that the user needs to install a local dns service, which we can then hook into with node to make things work if no internet is available, is still required here.

Comment 9

[Scott [:thecount] Downe]

Comment on attachment 8361350 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/414

What I like about this is it is an out of the box, it just works for most solution. It doesn't mean it cannot be configured from there.

I do kinda think we should have docs for how to set it up to be local only, but that can be a follow up.

Comment 10

[Jon Buckley [:jbuck]]

I've updated each patch with a link to the make-valet as a prerequisite, and added instructions to the make-valet about how to run it with no internet connection

Comment 11

[inactivate account for kate]

Comment on attachment 8361346 [details] [review]
https://github.com/mozilla/make-valet/pull/42

It's good, just comment that one line

Comment 12

[[github robot]]

Commit pushed to master at https://github.com/mozilla/make-valet

https://github.com/mozilla/make-valet/commit/db25dd43e1acd2ad9b2b13d2943055026ba9ed85
Bug 919177 - Add support for multiple subdomains

Comment 13

[[github robot]]

Commit pushed to master at https://github.com/mozilla/goggles.webmaker.org

https://github.com/mozilla/goggles.webmaker.org/commit/e14e66b5a86fb42c564e86fcca72d382e221e58b
Bug 919177 - Enable user subdomain by default

Comment 14

[[github robot]]

Commit pushed to master at https://github.com/mozilla/popcorn.webmaker.org

https://github.com/mozilla/popcorn.webmaker.org/commit/4f7480189db0e8df3f8bce29ce57f17c066d069e
Bug 919177 - Enable user subdomain by default

Comment 15

[[github robot]]

Commit pushed to master at https://github.com/mozilla/thimble.webmaker.org

https://github.com/mozilla/thimble.webmaker.org/commit/dee997c0258a2074e2212eb907a408403bf665e2
Bug 919177 - Enable user subdomain by default