919188 - help.intro in app-manager.dtd should use 'i.e.', not 'i.e' (dot is missing)

Status: RESOLVED FIXED

(DevTools Graveyard :: WebIDE, defect, P2)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: patch, v1

help.intro in app-manager.dtd should use 'i.e.', not 'i.e' (dot is missing).

Current state:
<!ENTITY help.intro "This tool will help you build and install web apps on compatible devices (i.e Firefox OS). The <strong>Apps</strong> tab will assist you in the validation and installation process of your app. The <strong>Device</strong> tab will give you information about the connected device. Use the bottom toolbar to connect to a device or start the simulator.">

Comment 1

[Paul Rouget [:paul]]

Comment on attachment 808181 [details] [diff] [review]
patch, v1

Thanks for the patch.

help.intro needs to be renamed help.intro2. We need to change the entity name when we change its value.

Comment 2

[Dão Gottwald [:dao]]

(In reply to Paul Rouget [:paul] from comment #1)
> help.intro needs to be renamed help.intro2. We need to change the entity
> name when we change its value.

Only if the change affects many locales, which it won't in this case. In fact, it looks like this won't even affect other en-* locales (and if it did you could just file bugs for them rather than changing the entity name): http://mxr.mozilla.org/l10n-central/search?string=i.e%20Firefox%20OS

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Two localizations have picked up the missing dot (en-ZA and pa-IN): http://mxr.mozilla.org/l10n-mozilla-aurora/search?string=i.e+Firefox&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=l10n-mozilla-aurora

If people create a localization for devtools, they are responsible to check that the texts they use are okay. If they keep the en-US version, they should pick up the new, updated en-US file without the "i.e".

Comment 4

[Dão Gottwald [:dao]]

(In reply to Archaeopteryx [:aryx] from comment #3)
> Two localizations have picked up the missing dot (en-ZA and pa-IN):
> http://mxr.mozilla.org/l10n-mozilla-aurora/search?string=i.
> e+Firefox&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=l10n-mozilla-aurora

Can you file bugs for them?

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: patch, v2, r=dao

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/d49c4551cd30

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Comment on attachment 808670 [details] [diff] [review]
patch, v2, r=dao

[Approval Request Comment]
Bug caused by (feature/regressing bug #): App Manager implementation
User impact if declined: App developers can see a typo (missing dot) in the app manager, translators who don't translate the devtools will also pick it up
Testing completed (on m-c, etc.): Landed on fx-team, no testing needed as it changes only text (adds a dot to be more precise)
Risk to taking this patch (and alternatives if risky): None
String or IDL/UUID changes made by this patch: None

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d49c4551cd30

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: patch for aurora, v2, r=dao, a=lsblakk

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/59532fdbd8f5