Closed Bug 919246 Opened 11 years ago Closed 6 years ago

Intermittent test_iframe_sandbox_navigation2.html | Test timed out

Categories

(Core :: Security, defect, P3)

Product:
Core
Component:
Security
Platform:
x86_64
macOS
Type:
defect

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: philor, Assigned: bobowen)

References

(Depends on 1 open bug)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

request longer timeout
1.30 KB, patch
bobowen
: review+
Details | Diff | Splinter Review 
https://tbpl.mozilla.org/php/getParsedLog.php?id=28202925&tree=Mozilla-Inbound
Rev4 MacOSX Snow Leopard 10.6 mozilla-inbound opt test mochitest-1 on 2013-09-21 18:54:25 PDT for push f2b5dbc01325
slave: talos-r4-snow-045

19:08:06     INFO -  145332 INFO TEST-PASS | /tests/content/html/content/test/test_iframe_sandbox_navigation2.html | Test 17: navigate _self with window.open(): this navigation should be allowed by a sandboxed document
19:13:30     INFO -  145333 ERROR TEST-UNEXPECTED-FAIL | /tests/content/html/content/test/test_iframe_sandbox_navigation2.html | Test timed out.
(not very informative screenshot)
9:13:33     INFO -  145334 INFO TEST-END | /tests/content/html/content/test/test_iframe_sandbox_navigation2.html | finished in 325291ms
Assignee: nobody → bobowencode
Depends on: 885140
This seems to have suddenly started failing more often on Android, on most trees it appears around this commit:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=5f00adf8395a

I should try and find time to get back to bug 885140 as that was try to squash this orange as well.
(In reply to Bob Owen (:bobowen) from comment #41)
> This seems to have suddenly started failing more often on Android, on most
> trees it appears around this commit:

I think we starting running tests on the Android 4.3 emulator around that time. Tests on the Android 4.3 emulator usually run in time similar to corresponding tests on the Android 2.3 emulator, but I have seen a few exceptions now.

A quick survey of test logs suggest this test typically runs in 150 to 250 seconds on Android 2.3 and 200 seconds+ on Android 4.3.
Maybe it's best to simply use a longer run-time to allow for slower platforms?

Do you want to do the same for test_iframe_sandbox_navigation.html?
Attachment #8610252 - Flags: review?(bobowen.code)
Comment on attachment 8610252 [details] [diff] [review]
request longer timeout

Review of attachment 8610252 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to Geoff Brown [:gbrown] from comment #220)
> (In reply to Bob Owen (:bobowen) from comment #41)
> > This seems to have suddenly started failing more often on Android, on most
> > trees it appears around this commit:
> 
> I think we starting running tests on the Android 4.3 emulator around that
> time. Tests on the Android 4.3 emulator usually run in time similar to
> corresponding tests on the Android 2.3 emulator, but I have seen a few
> exceptions now.

Ah, this seems to be a different problem from the original timeouts then.

This test opens quite a few new tabs (if I remember correctly).
Some of the other iframe sandbox tests which seem to be much slower on Android 4.3, also do this.
(This is just from a spot check, I haven't done an extensive survey :-) )

(In reply to Geoff Brown [:gbrown] from comment #221)
> Created attachment 8610252 [details] [diff] [review]
> request longer timeout
> 
> Maybe it's best to simply use a longer run-time to allow for slower
> platforms?
> 
> Do you want to do the same for test_iframe_sandbox_navigation.html?

This seems to make sense for both of these, for this particular problem.

We should probably leave the bugs open for the more rare timeout issue.
Which I don't think would be fixed by longer timeouts.
Attachment #8610252 - Flags: review?(bobowen.code) → review+
Keywords: leave-open
Bulk assigning P3 to all open intermittent bugs without a priority set in Firefox components per bug 1298978.
Priority: -- → P3
The leave-open keyword is there and there is no activity for 6 months.
:bobowen, maybe it's time to close this bug?
Flags: needinfo?(bobowencode)
(In reply to Release mgmt bot [:sylvestre / :calixte] from comment #256)
> The leave-open keyword is there and there is no activity for 6 months.
> :bobowen, maybe it's time to close this bug?

I'm guessing something else fixed this then.
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: needinfo?(bobowencode)
Keywords: leave-open
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: