Closed
Bug 919247
Opened 11 years ago
Closed 10 years ago
crash in nsMsgDBView::SetThreadIgnored(nsIMsgThread*, unsigned int, bool)
Categories
(MailNews Core :: Backend, defect)
Tracking
(thunderbird27 fixed, thunderbird28 fixed, thunderbird_esr2428+ fixed)
VERIFIED
FIXED
Thunderbird 29.0
People
(Reporter: wsmwk, Assigned: mkmelin)
References
Details
(Keywords: crash)
Crash Data
Attachments
(1 file)
1.48 KB,
patch
|
standard8
:
review+
standard8
:
approval-comm-aurora+
standard8
:
approval-comm-beta+
standard8
:
approval-comm-esr24+
|
Details | Diff | Splinter Review |
#26 crash for TB24 This bug was filed from the Socorro interface and is report bp-9c29439e-1d38-4a18-ab18-1e5f12130921. ============================================================= 0 xul.dll nsMsgDBView::SetThreadIgnored(nsIMsgThread *,unsigned int,bool) mailnews/base/src/nsMsgDBView.cpp 1 xul.dll nsMsgDBView::ToggleIgnored(unsigned int *,int,unsigned int *,bool *) mailnews/base/src/nsMsgDBView.cpp 2 xul.dll nsMsgDBView::NavigateFromPos(int,unsigned int,unsigned int *,unsigned int *,unsigned int *,bool) mailnews/base/src/nsMsgDBView.cpp 3 xul.dll nsMsgDBView::ViewNavigate(int,unsigned int *,unsigned int *,unsigned int *,bool) mailnews/base/src/nsMsgDBView.cpp 4 xul.dll NS_InvokeByIndex xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp
Comment 1•11 years ago
|
||
Thanks!
Assignee | ||
Comment 2•11 years ago
|
||
This might have something to do with the fact that you can undo the ignore from the notification long afterwards, and perhaps the the db goes away during that time. Anyway, this is why it's crashing (m_keys index is validated to be ok). Ignore subthread should have the same problem, so i added the check there too.
Attachment #826510 -
Flags: review?(mbanner)
Assignee | ||
Updated•11 years ago
|
Status: NEW → ASSIGNED
Hardware: x86 → All
Comment 3•10 years ago
|
||
Comment on attachment 826510 [details] [diff] [review] proposed fix Looks good, r=Standard8
Attachment #826510 -
Flags: review?(mbanner) → review+
Assignee | ||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/comm-central/rev/2e48a9153f8d -> FIXED
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 29.0
Assignee | ||
Updated•10 years ago
|
Attachment #826510 -
Flags: approval-comm-esr24?
Comment 6•10 years ago
|
||
Comment on attachment 826510 [details] [diff] [review] proposed fix [Triage Comment] Yep, lets get this out for some testing, and release in the next cycle.
Attachment #826510 -
Flags: approval-comm-beta+
Attachment #826510 -
Flags: approval-comm-aurora+
Comment 7•10 years ago
|
||
https://hg.mozilla.org/releases/comm-aurora/rev/d5174e056ea6 https://hg.mozilla.org/releases/comm-beta/rev/ae1dc00b9152
status-thunderbird27:
--- → fixed
status-thunderbird28:
--- → fixed
Updated•10 years ago
|
tracking-thunderbird_esr24:
--- → 28+
Updated•10 years ago
|
Attachment #826510 -
Flags: approval-comm-esr24? → approval-comm-esr24+
Comment 8•10 years ago
|
||
https://hg.mozilla.org/releases/comm-esr24/rev/398539608a8b
status-thunderbird_esr24:
--- → fixed
Reporter | ||
Comment 9•10 years ago
|
||
v.fixed - does not appear in TB31 nor in newer TB24.x
Status: RESOLVED → VERIFIED
Crash Signature: [@ nsMsgDBView::SetThreadIgnored(nsIMsgThread*, unsigned int, bool)] → [@ nsMsgDBView::SetThreadIgnored(nsIMsgThread*, unsigned int, bool) ]
You need to log in
before you can comment on or make changes to this bug.
Description
•