Closed Bug 919265 Opened 6 years ago Closed 6 years ago

Leak with VTTCue.getCueAsHTML

Categories

(Core :: Audio/Video, defect)

x86_64
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla27

People

(Reporter: jruderman, Assigned: reyre)

References

(Blocks 1 open bug)

Details

(Keywords: memory-leak, regression, testcase)

Attachments

(4 files)

Attached file testcase
1. Set
     user_pref("media.webvtt.enabled", true);
2. Run with XPCOM_MEM_LEAK_LOG=2
3. Load the testcase
4. Quit

Result: leak

Maybe a regression from bug 895091?

http://mxr.mozilla.org/mozilla-central/source/content/media/test/crashtests/882549.html?force=1 seems to test the same thing, so I wonder why the crashtest suite didn't catch this bug.
Attached file what leaked?
The crash test for bug 882549 won't work anymore as TextTrackCue isn't defined anymore. It's VTTCue now. That's probably why we haven't heard anything from it about the leak.
In that case, two tests should be updated to use the new name:
  content/media/test/crashtests/882549.html
  content/media/test/crashtests/894104.html
I'll take a look at this and update those two crashtests with the correct name.
Assignee: nobody → rick.eyre
Comment on attachment 809371 [details] [diff] [review]
Part 1 v1: Fix TextTrackCue() crashtests to use VTTCue() r=bz

r=me
Attachment #809371 - Flags: review?(bzbarsky) → review+
Comment on attachment 809375 [details] [diff] [review]
Part 2 v1: Add ClearOnShutdown() call on the static WebVTTParserWrapper r=bz

r=me
Attachment #809375 - Flags: review?(bzbarsky) → review+
Thanks for review bz.

Try push: https://tbpl.mozilla.org/?tree=Try&rev=f64ea16e373b
Looks green.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/fd0ad8462ba7
https://hg.mozilla.org/mozilla-central/rev/07e358bb9954
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.