919265 - Leak with VTTCue.getCueAsHTML

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Jesse Ruderman]

Attachment: testcase

1. Set
     user_pref("media.webvtt.enabled", true);
2. Run with XPCOM_MEM_LEAK_LOG=2
3. Load the testcase
4. Quit

Result: leak

Maybe a regression from bug 895091?

http://mxr.mozilla.org/mozilla-central/source/content/media/test/crashtests/882549.html?force=1 seems to test the same thing, so I wonder why the crashtest suite didn't catch this bug.

Comment 1

[Jesse Ruderman]

Attachment: what leaked?

Comment 2

[Rick Eyre (:reyre)]

The crash test for bug 882549 won't work anymore as TextTrackCue isn't defined anymore. It's VTTCue now. That's probably why we haven't heard anything from it about the leak.

Comment 3

[Jesse Ruderman]

In that case, two tests should be updated to use the new name:
  content/media/test/crashtests/882549.html
  content/media/test/crashtests/894104.html

Comment 4

[Rick Eyre (:reyre)]

I'll take a look at this and update those two crashtests with the correct name.

Comment 5

[Rick Eyre (:reyre)]

Attachment: Part 1 v1: Fix TextTrackCue() crashtests to use VTTCue() r=bz

Comment 6

[Rick Eyre (:reyre)]

Attachment: Part 2 v1: Add ClearOnShutdown() call on the static WebVTTParserWrapper r=bz

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 809371 [details] [diff] [review]
Part 1 v1: Fix TextTrackCue() crashtests to use VTTCue() r=bz

r=me

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 809375 [details] [diff] [review]
Part 2 v1: Add ClearOnShutdown() call on the static WebVTTParserWrapper r=bz

r=me

Comment 9

[Rick Eyre (:reyre)]

Thanks for review bz.

Try push: https://tbpl.mozilla.org/?tree=Try&rev=f64ea16e373b

Comment 10

[Rick Eyre (:reyre)]

Looks green.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fd0ad8462ba7
https://hg.mozilla.org/integration/mozilla-inbound/rev/07e358bb9954

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/fd0ad8462ba7
https://hg.mozilla.org/mozilla-central/rev/07e358bb9954