91930 - Browser not opening a window on first launch

Status: VERIFIED FIXED

(SeaMonkey :: General, defect)

Description

[Grace Bush]

Using branch build 2001072303 Mac Stub Installer (recommended setup type)
1. Install
2. Create profile/migrate old profile
3. activate or cancel or relaunch old profile

actual results:  Netscape 6 menu is seen, but now browser
If I open file/Navigator Window, a small window opens (size of popup) and then 
it is usable.

expected results: normal size browser window opens.

Comment 1

[lchiang]

ah! Could this be related to http://bugzilla.mozilla.org/show_bug.cgi?id=91788?

cc: selmer, sdagley, jaggernaut, jrgm, etc.

Comment 2

[Steve Dagley]

I didn't see this on my build at home this morning but I was using an existing 
profile.  I'm re-building my office build now to pick up the other changes from 
the weekend and will check with a new profile when it finishes.

Comment 3

[Grace Bush]

launching from icon on desktop opens a browser window but same popup size

Comment 4

[selmer (gone)]

PDT+, we need this resolved ASAP!

Comment 5

[John Morrison]

Just relaying some stuff jag told me, but that I have duplicated. This happens
when using '-profilemanager' option. A window is in fact opened (look at the 
Tasks menu) but it is not visible. However, if I manually remove the change
for bug 91788, I can still reproduce this bug on Mac, so this is not the cause.

Comment 6

[lchiang]

selmer - need to reassign this to proper engineer.

Comment 7

[selmer (gone)]

You just got that comment in ahead of me reassigning it :-)

Steve, I tagged you because you said you're working on it.  Please do the right
thing from there.  We need a checkin today if we can get enough confidence.  I'm
concerned about jrgm's comment since we may have mis-attributed the cause and
there were a number of other checkins recently.

Has anyone run builds from the last several days to pinpoint when this actually
started?

Comment 8

[jag (Peter Annema)]

I think it's the infamous bug 65993.

I can reproduce this on my linux box with a certain regularity, but not always,
so it seems like a timing issue. Anyway, my guess is that window watcher doesn't
quite know how to deal with width/height set to NS_SIZETOCONTENT, so I'll work
around that by not passing in a height/width when they're set to
NS_SIZETOCONTENT. We're already doing that from XUL anyway, so passing that
value in is redundant.

Patch coming up.

Comment 9

[jag (Peter Annema)]

Attachment: [patch] don't pass in width/height of -1 (NS_SIZETOCONTENT).

Comment 10

[jag (Peter Annema)]

So this seems to fix my linux box, but my Mac remains stubborn. Being slightly
paranoid, I'm now doing a complete rebuild on the Mac, just in case.

Comment 11

[Steve Dagley]

Launching via the 'Netscape Profile Manager' icon seems to be a reliable way to 
invoke this bug (5 out of 5 tries for me)

Comment 12

[Steve Dagley]

And no, the patch from 07/23/01 14:03 doesn't quite work on Mac.  I do get a 
window but it's sized _very_ small - only wide enough to show part of the Reload 
button and only tall enough for 4 sidebar tabs with the Classic skin

Comment 13

[jag (Peter Annema)]

Hmmm, it seems to be working fine for me now in a clean build on the Mac
(trunk).

Comment 14

[Steve Dagley]

Having seen it work on jag's Mac I too am trying a full re-build to see if in 
fact his patch does work

Comment 15

[Steve Dagley]

Fix verified from a full re-build.  Reassigning to jaggernaut for checkin, r=
sdagley.

Comment 16

[hirata masakazu]

I have noticed that opening Mozilla by opening an unresponsive link in Sherlock
results in no window behavior and subsequent weirdness.
2001072304 trunk for Mac.  

Comment 17

[jag (Peter Annema)]

Hirata, could you file a new bug on that? I think it's unrelated to this.

Comment 18

[jag (Peter Annema)]

sr=jst

Comment 19

[jag (Peter Annema)]

Should be all fixed now.

Comment 20

[jag (Peter Annema)]

*** Bug 91947 has been marked as a duplicate of this bug. ***

Comment 21

[Grace Bush]

verified   working on branch builds 2001072303 Mac/2001072304 Linux
adding vtrunk reminder

Comment 22

[Grace Bush]

verified on trunk build 2001081004