919457 - Separate the concepts of "not available on the main thread" and "uses crazy worker stuff"

Status: RESOLVED FIXED

(Core :: DOM: Workers, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

The attached patch separates workers: True and nativeOwnership: workers, and converts most of the workers: True objects away from inheriting from DOMBindingBase.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 808498 [details] [diff] [review]
Patch

>+++ b/dom/bindings/Codegen.py

>                    # Workers use raw pointers for new-object return
>                    # values or something
>-                   self.descriptor.workers)
>+                   self.descriptor.nativeOwnership == 'worker')

That should check the descriptor for self.returnType's interface, just like the 'owned' case above, no?

>+        if descriptorProvider.nativeOwnership == 'worker':

That's nonsense; a descriptor _provider_ doesn't have nativeOwnership...

On the other hand, callbacks on workers are actuall callbacks now.  Can you just nix this entire bit:

>+        if descriptorProvider.nativeOwnership == 'worker':
>             if type.nullable():
>                 return CGGeneric("JSObject*")
>             return CGGeneric("JSObject&")

please?  Looks like I forgot to do it.  :(

>+++ b/dom/workers/Location.h
>+#include "mozilla/dom/WorkerLocationBinding.h"

Put this in the .cpp, please.

>+    return WorkerLocationBinding_workers::Wrap(aCx, aScope, this);

And this bit.  It's virtual anyway, so not like it's getting inlined...

>+++ b/dom/workers/Navigator.h
>+#include "mozilla/dom/WorkerNavigatorBinding.h"

Likewise.

r=me with those fixed.

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d94a30d4ed76

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

And https://hg.mozilla.org/integration/mozilla-inbound/rev/db16370f7cce to fix the build.

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

And backed out because that didn't fix it :-/

https://hg.mozilla.org/integration/mozilla-inbound/rev/7fab5b625860
https://hg.mozilla.org/integration/mozilla-inbound/rev/8888cdebbe10

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Somehow I botched a merge.

Fixed and relanded:  https://hg.mozilla.org/integration/mozilla-inbound/rev/cd5ae0c57f7d

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/cd5ae0c57f7d