Closed
Bug 919496
Opened 12 years ago
Closed 12 years ago
[app manager] once an app has been installed, it doesn't show up in the "installed app" tab
Categories
(DevTools Graveyard :: WebIDE, defect, P1)
Tracking
(firefox26 verified, firefox27 verified, b2g-v1.2 fixed)
VERIFIED
FIXED
Firefox 27
People
(Reporter: paul, Assigned: paul)
References
Details
Attachments
(1 file, 3 obsolete files)
9.15 KB,
patch
|
ochameau
:
review+
lsblakk
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Updated•12 years ago
|
Priority: -- → P1
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → paul
Assignee | ||
Updated•12 years ago
|
Whiteboard: [needed-in-aurora-26]
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #809778 -
Flags: review?(poirot.alex)
Comment 2•12 years ago
|
||
Comment on attachment 809778 [details] [diff] [review]
Patch v1
Review of attachment 809778 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good, but we can easily write a test for the new actor function.
See getAll test:
http://mxr.mozilla.org/mozilla-central/source/toolkit/devtools/apps/tests/unit/test_webappsActor.js#36
You can run this test on firefox desktop by enabling the test:
http://mxr.mozilla.org/mozilla-central/source/toolkit/devtools/apps/tests/unit/xpcshell.ini
and commenting two icon related tests.
::: browser/devtools/app-manager/webapps-store.js
@@ +10,5 @@
> const dbgClient = Cu.import("resource://gre/modules/devtools/dbg-client.jsm");
> dbgClient.UnsolicitedNotifications.appOpen = "appOpen";
> dbgClient.UnsolicitedNotifications.appClose = "appClose"
> +dbgClient.UnsolicitedNotifications.appInstall = "appInstall";
> +dbgClient.UnsolicitedNotifications.appUninstall = "appUninstall";
In bug 919981's patch, I'm registering these notifications, and also appOpen/Close in dbg-client.jsm, so I think we no longer need them here.
@@ +224,5 @@
> + };
> +
> + client.request(request, (res) => {
> + if (res.error) {
> + return deferred.reject(res.error);
There is no `deferred` here. we should throw or console.error this message.
::: toolkit/devtools/server/actors/webapps.js
@@ +551,5 @@
> + }
> +
> + let deferred = promise.defer();
> + let reg = DOMApplicationRegistry;
> + let app = reg.getAppByManifestURL(manifestURL);
getAppByManifestURL isn't consistent with getAll. We miss the app manifest. app.manifest should be the app manifest, as a JSON object, but here, it's undefined.
We can fetch it like this:
let deferred = promise.defer();
reg.getManifestFor(manifestURL, function (manifest) {
app.manifest = manifest;
deferred.resolve({app: app});
});
return deferred.promise;
Attachment #809778 -
Flags: review?(poirot.alex)
Assignee | ||
Comment 3•12 years ago
|
||
Attachment #809778 -
Attachment is obsolete: true
Attachment #810511 -
Flags: review?(poirot.alex)
Comment 4•12 years ago
|
||
Comment on attachment 810511 [details] [diff] [review]
Patch v2
Review of attachment 810511 [details] [diff] [review]:
-----------------------------------------------------------------
Works great!
Attachment #810511 -
Flags: review?(poirot.alex) → review+
Assignee | ||
Updated•12 years ago
|
Keywords: checkin-needed
Comment 5•12 years ago
|
||
Flags: in-testsuite+
Keywords: checkin-needed
Whiteboard: [needed-in-aurora-26] → [needed-in-aurora-26][fixed-in-fx-team]
Comment 6•12 years ago
|
||
Backed out for assertions, eg:
https://tbpl.mozilla.org/php/getParsedLog.php?id=28407575&tree=Fx-Team
remote: https://hg.mozilla.org/integration/fx-team/rev/a9ed5d97225f
Updated•12 years ago
|
Whiteboard: [needed-in-aurora-26][fixed-in-fx-team] → [needed-in-aurora-26]
Assignee | ||
Comment 7•12 years ago
|
||
Assignee | ||
Updated•12 years ago
|
Whiteboard: [needed-in-aurora-26] → [blocked by bug 919981]
Assignee | ||
Comment 8•12 years ago
|
||
Attachment #810511 -
Attachment is obsolete: true
Attachment #811109 -
Attachment is obsolete: true
Attachment #812710 -
Flags: review?(poirot.alex)
Updated•12 years ago
|
Attachment #812710 -
Flags: review?(poirot.alex) → review+
Assignee | ||
Updated•12 years ago
|
Keywords: checkin-needed
Whiteboard: [blocked by bug 919981] → [land-in-fx-team]
Comment 9•12 years ago
|
||
Keywords: checkin-needed
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
![]() |
||
Comment 10•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 27
Assignee | ||
Comment 11•12 years ago
|
||
Comment on attachment 812710 [details] [diff] [review]
Patch V3
[Approval Request Comment]
Bug caused by (feature/regressing bug #): new feature (app manager)
User impact if declined: list of installed apps not updated
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): low
String or IDL/UUID changes made by this patch: none
Attachment #812710 -
Flags: approval-mozilla-aurora?
Assignee | ||
Updated•12 years ago
|
Whiteboard: [waiting-for-aurora-approval]
Updated•12 years ago
|
Attachment #812710 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 12•12 years ago
|
||
status-b2g-v1.2:
--- → fixed
status-firefox26:
--- → fixed
status-firefox27:
--- → fixed
Whiteboard: [waiting-for-aurora-approval]
Comment 13•12 years ago
|
||
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:27.0) Gecko/20100101 Firefox/27.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:26.0) Gecko/20100101 Firefox/26.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:27.0) Gecko/20100101 Firefox/27.0
Mozilla/5.0 (X11; Linux i686; rv:26.0) Gecko/20100101 Firefox/26.0
Mozilla/5.0 (X11; Linux i686; rv:27.0) Gecko/20100101 Firefox/27.0
Verified as fixed on Fx 26 beta 3 (20131107161719) and latest Aurora (20131108004000) using Firefox OS 1.2 or 1.3 Simulator.
Comment 14•11 years ago
|
||
See also: Bug 986979
Updated•7 years ago
|
Product: Firefox → DevTools
Updated•6 years ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•