Closed
Bug 919513
Opened 12 years ago
Closed 12 years ago
content/media/directshow fails to compile on GCC
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla27
People
(Reporter: jacek, Assigned: jacek)
References
Details
Attachments
(1 file)
|
3.90 KB,
patch
|
cpearce
:
review+
|
Details | Diff | Splinter Review |
There are two broblems:
- Cross compile from sensitive OS requres all platform headers to be lower-case
- __uuidof support. Got that mingw (mingw-w64) provides template-based emulations in headers. It works well and transparently for platform-provided interfaces, but requires an additional effort in declaration and the code declares its own DECLSPEC_UUID types. Changed webrtc files seem to be Mozilla-only ones.
Attachment #808552 -
Flags: review?(cpearce)
|
||
Comment 1•12 years ago
|
||
Comment on attachment 808552 [details] [diff] [review]
patch.diff
Review of attachment 808552 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks!
Attachment #808552 -
Flags: review?(cpearce) → review+
|
Assignee | |
Comment 2•12 years ago
|
||
Thanks for the review.
https://hg.mozilla.org/integration/mozilla-inbound/rev/8e10ba98b509
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in
before you can comment on or make changes to this bug.
Description
•