919702 - Adjust GA experiment code to only execute when f=[0-9]+ is *not* in query string

Status: VERIFIED FIXED

(www.mozilla.org :: Bedrock, defect)

Description

[Chris More [:cmore]]

To reproduce:

1) Visit: http://www.mozilla.org/en-US/firefox/new/?f=24 or http://www.mozilla.org/en-US/firefox/new/?f=25

2) View source

3) Look for GA experiment code

Expected results:

No GA experiment code

Actual:

GA experiment code shows up regardless if f= is in the URL. To keep GA content experiments from looping on themselves, the code here:

https://github.com/mozilla/bedrock/blob/b257564c4bf1ba56bf6128216aa29b13351f4b78/bedrock/firefox/templates/firefox/new.html#L17

...should also include an additional statement in the conditional to check to see if the f= is *not* defined.

Comment 1

[Chris More [:cmore]]

something like:

{% if request.locale == 'en-US' && request.get('f') is not defined %}

Comment 2

[Mike Alexis [:malexis]]

Josh is going to take a look since this is urgent and blocking /new testing.

Comment 3

[Chris More [:cmore]]

(In reply to Mike Alexis [:malexis] from comment #2)
> Josh is going to take a look since this is urgent and blocking /new testing.

it actually blocks the /firstrun testing which uses /new/ to get the funnelcake.

Comment 4

[Chris More [:cmore]]

pmac/gareth: I'd like to get this on production Tuesday AM (2013-09-24) and Gareth can verify GA and enable the experiment. We can only know for sure if this works if we enable the experiment on product and any requests to ?f=24 or ?f=25 do not get pulled into the experiment.

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/0b1bab59e4763d21f3b7b3f7b284ffae69d821ef
Fix Bug 919702

Modify the GA Content Experiment code to be a no-op if the querystring
matches the regex /[?&]f=[0-9]+/

https://github.com/mozilla/bedrock/commit/9646bacca9d917b4d7260a769063fbf2b776d0b1
Merge pull request #1264 from jgmize/bug-919702

Fix Bug 919702 - Adjust GA experiment code to only execute when f=[0-9]+ is *not* in query string

Comment 6

[raymond [:retornam] (inactive)]

this fixed and on production