Closed Bug 919706 Opened 6 years ago Closed 6 years ago

Localize search/replace UI

Categories

(DevTools :: Source Editor, defect, P2)

x86
macOS
defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 27

People

(Reporter: anton, Assigned: anton)

References

Details

Attachments

(1 file)

This is a followup for bug 912260.
Assignee: nobody → anton
Status: NEW → ASSIGNED
Blocks: 816756
No longer depends on: 816756
Attached patch WIP 1Splinter Review
Made search UI localizable and re-used an existing string. Didn't do anything to the replace UI because we don't expose it for now *and* I will probably rewrite the search addon in bug 912260. But this patch should get us out of the door in terms of l10n strings for the upcoming merge.
Attachment #821277 - Flags: review?(rcampbell)
Comment on attachment 821277 [details] [diff] [review]
WIP 1

Review of attachment 821277 [details] [diff] [review]:
-----------------------------------------------------------------

my only concern is how do we make sure we don't lose this when we update CodeMirror?

::: browser/devtools/sourceeditor/codemirror/search/search.js
@@ +49,4 @@
>    function doSearch(cm, rev) {
> +    if (!queryDialog) {
> +      queryDialog = cm.l10n('findCmd.promptMessage') +
> +        ' <input type="text" style="width: 10em"/>';

reusing the existing label here. Good.

Not sure about the lazy initialization, but ok.
Attachment #821277 - Flags: review?(rcampbell) → review+
> my only concern is how do we make sure we don't lose this when we update CodeMirror?

That's why I updated the upgrade section in the README. I don't think there are other solutions since strings are hard-coded.
https://hg.mozilla.org/mozilla-central/rev/684d1c36eace
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 27
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.