919706 - Localize search/replace UI

Status: RESOLVED FIXED

(DevTools :: Source Editor, defect, P2)

Description

[Anton Kovalyov (:anton)]

This is a followup for bug 912260.

Comment 1

[Anton Kovalyov (:anton)]

Attachment: WIP 1

Made search UI localizable and re-used an existing string. Didn't do anything to the replace UI because we don't expose it for now *and* I will probably rewrite the search addon in bug 912260. But this patch should get us out of the door in terms of l10n strings for the upcoming merge.

Comment 2

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 821277 [details] [diff] [review]
WIP 1

Review of attachment 821277 [details] [diff] [review]:
-----------------------------------------------------------------

my only concern is how do we make sure we don't lose this when we update CodeMirror?

::: browser/devtools/sourceeditor/codemirror/search/search.js
@@ +49,4 @@
>    function doSearch(cm, rev) {
> +    if (!queryDialog) {
> +      queryDialog = cm.l10n('findCmd.promptMessage') +
> +        ' <input type="text" style="width: 10em"/>';

reusing the existing label here. Good.

Not sure about the lazy initialization, but ok.

Comment 3

[Anton Kovalyov (:anton)]

> my only concern is how do we make sure we don't lose this when we update CodeMirror?

That's why I updated the upgrade section in the README. I don't think there are other solutions since strings are hard-coded.

Comment 4

[Anton Kovalyov (:anton)]

https://hg.mozilla.org/integration/fx-team/rev/684d1c36eace

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/684d1c36eace