919729 - Remove MOZILLA_INTERNAL_API checks from nsIFrame.h, aside from the #error at the top

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Daniel Holbert [:dholbert]]

nsIFrame currently has:

> 12 #ifndef MOZILLA_INTERNAL_API
> 13 #error This header/class should only be used within Mozilla code. It should not be used by extensions.
> 14 #endif
[...]
> 809 #ifdef MOZILLA_INTERNAL_API
> 810   /** Also forward GetVisitedDependentColor to the style context */
> 811   nscolor GetVisitedDependentColor(nsCSSProperty aProperty)
> 812     { return mStyleContext->GetVisitedDependentColor(aProperty); }
> 813 #endif

and several other similar #ifdefs.

All of those checks beyond the first are superfluous (I think?) ever since the #error was added on line 13.  Those checks (and their code for when the symbol isn't defined) should probably be removed.

Comment 1

[Biru [:poiru]]

Attachment: Remove unnecessary MOZILLA_INTERNAL_API checks from nsIFrame.h

Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=dd2d17baaa00

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 809334 [details] [diff] [review]
Remove unnecessary MOZILLA_INTERNAL_API checks from nsIFrame.h

r=me

Comment 3

[Biru [:poiru]]

Attachment: Remove unnecessary MOZILLA_INTERNAL_API checks from nsIFrame.h

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/740e70e5716e

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/740e70e5716e