Closed Bug 919729 Opened 7 years ago Closed 7 years ago

Remove MOZILLA_INTERNAL_API checks from nsIFrame.h, aside from the #error at the top

Categories

(Core :: Layout, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla27

People

(Reporter: dholbert, Assigned: poiru)

References

Details

Attachments

(1 file, 1 obsolete file)

nsIFrame currently has:

> 12 #ifndef MOZILLA_INTERNAL_API
> 13 #error This header/class should only be used within Mozilla code. It should not be used by extensions.
> 14 #endif
[...]
> 809 #ifdef MOZILLA_INTERNAL_API
> 810   /** Also forward GetVisitedDependentColor to the style context */
> 811   nscolor GetVisitedDependentColor(nsCSSProperty aProperty)
> 812     { return mStyleContext->GetVisitedDependentColor(aProperty); }
> 813 #endif

and several other similar #ifdefs.

All of those checks beyond the first are superfluous (I think?) ever since the #error was added on line 13.  Those checks (and their code for when the symbol isn't defined) should probably be removed.
Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=dd2d17baaa00
Assignee: nobody → birunthan
Status: NEW → ASSIGNED
Attachment #809334 - Flags: review?(bzbarsky)
Comment on attachment 809334 [details] [diff] [review]
Remove unnecessary MOZILLA_INTERNAL_API checks from nsIFrame.h

r=me
Attachment #809334 - Flags: review?(bzbarsky) → review+
Keywords: checkin-needed
OS: Linux → All
Hardware: x86_64 → All
https://hg.mozilla.org/mozilla-central/rev/740e70e5716e
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.