919748 - Bottom divider is lost in Reading List

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Sriram Ramasubramanian [:sriram]]

http://cl.ly/image/071I0s3x2c0a

STR:
1. Add an entry to Reading List.

Expected: Bottom divider should be shown.

Actual: No divider.

Comment 1

[Lucas Rocha (:lucasr)]

(In reply to Sriram Ramasubramanian [:sriram] from comment #0)
> http://cl.ly/image/071I0s3x2c0a
> 
> STR:
> 1. Add an entry to Reading List.
> 
> Expected: Bottom divider should be shown.
> 
> Actual: No divider.

Is that a regression?

Comment 2

[Sriram Ramasubramanian [:sriram]]

Yes. I remember seeing a divider when I implemented it.

Comment 3

[:Margaret Leibovic]

This issue still exists. For some reason the bottom row of the reading list ListView doesn't have a border.

Comment 4

[Vivek Balakrishnan[:vivek]]

Attachment: 919748.patch

A simple patch that fixes the list view height.

Comment 5

[:Margaret Leibovic]

Comment on attachment 8503403 [details] [diff] [review]
919748.patch

Review of attachment 8503403 [details] [diff] [review]:
-----------------------------------------------------------------

I see this is what we do for the bookmarks panel:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/layout/home_bookmarks_panel.xml

But for other panels it looks like we use a layout weight:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/layout/home_list.xml#13

Also, home_bookmarks_panel uses a FrameLayout, whereas the other panels use LinearLayouts. I'm fine with the approach of this patch, especially since it's such a small fix, but this might be a good time to audit out panel layouts to make them a bit more consistent.

Comment 6

[Lucas Rocha (:lucasr)]

Comment on attachment 8503403 [details] [diff] [review]
919748.patch

Review of attachment 8503403 [details] [diff] [review]:
-----------------------------------------------------------------

Yep.

Comment 7

[:Margaret Leibovic]

Comment on attachment 8503403 [details] [diff] [review]
919748.patch

I think it's fine to go ahead and land this low-risk patch (and we could even uplift this as well).

But let's file a follow-up to audit these home panel styles to see if we can be more consistent.

Comment 8

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/db6c7114b913

Comment 9

[:Margaret Leibovic]

Oops, landed with the wrong patch author. Fixed:
https://hg.mozilla.org/integration/fx-team/rev/60b1791ae0cc
https://hg.mozilla.org/integration/fx-team/rev/e23264b514a2

vivek, for future reference, you should make sure to export your patches with your username and a commit message :)

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e23264b514a2

Comment 11

[Teodora Vermesan (:TeoVermesan)]

Adding a page to reading list and going to the reading list panel, the item has a border divider.
Verified fixed on:
Devices: Alcatel One Touch(Android 4.1.2)
Build: Firefox for Android 36.0a1 (2014-11-23)