Closed
Bug 919748
Opened 11 years ago
Closed 10 years ago
Bottom divider is lost in Reading List
Categories
(Firefox for Android Graveyard :: Theme and Visual Design, defect)
Tracking
(fennec+)
VERIFIED
FIXED
Firefox 36
Tracking | Status | |
---|---|---|
fennec | + | --- |
People
(Reporter: sriram, Assigned: vivek, Mentored)
References
Details
(Keywords: polish, regression, Whiteboard: [lang=java])
Attachments
(1 file)
http://cl.ly/image/071I0s3x2c0a STR: 1. Add an entry to Reading List. Expected: Bottom divider should be shown. Actual: No divider.
Reporter | ||
Updated•11 years ago
|
Blocks: new-about-home
Comment 1•11 years ago
|
||
(In reply to Sriram Ramasubramanian [:sriram] from comment #0) > http://cl.ly/image/071I0s3x2c0a > > STR: > 1. Add an entry to Reading List. > > Expected: Bottom divider should be shown. > > Actual: No divider. Is that a regression?
Reporter | ||
Comment 2•11 years ago
|
||
Yes. I remember seeing a divider when I implemented it.
Updated•11 years ago
|
Keywords: regression
Updated•11 years ago
|
tracking-fennec: ? → +
Comment 3•10 years ago
|
||
This issue still exists. For some reason the bottom row of the reading list ListView doesn't have a border.
Mentor: lucasr.at.mozilla
Whiteboard: [lang=java]
Assignee | ||
Comment 4•10 years ago
|
||
A simple patch that fixes the list view height.
Attachment #8503403 -
Flags: feedback?(margaret.leibovic)
Attachment #8503403 -
Flags: feedback?(lucasr.at.mozilla)
Updated•10 years ago
|
Assignee: nobody → vivekb.balakrishnan
Comment 5•10 years ago
|
||
Comment on attachment 8503403 [details] [diff] [review] 919748.patch Review of attachment 8503403 [details] [diff] [review]: ----------------------------------------------------------------- I see this is what we do for the bookmarks panel: http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/layout/home_bookmarks_panel.xml But for other panels it looks like we use a layout weight: http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/layout/home_list.xml#13 Also, home_bookmarks_panel uses a FrameLayout, whereas the other panels use LinearLayouts. I'm fine with the approach of this patch, especially since it's such a small fix, but this might be a good time to audit out panel layouts to make them a bit more consistent.
Attachment #8503403 -
Flags: feedback?(margaret.leibovic) → feedback+
Comment 6•10 years ago
|
||
Comment on attachment 8503403 [details] [diff] [review] 919748.patch Review of attachment 8503403 [details] [diff] [review]: ----------------------------------------------------------------- Yep.
Attachment #8503403 -
Flags: feedback?(lucasr.at.mozilla) → feedback+
Comment 7•10 years ago
|
||
Comment on attachment 8503403 [details] [diff] [review] 919748.patch I think it's fine to go ahead and land this low-risk patch (and we could even uplift this as well). But let's file a follow-up to audit these home panel styles to see if we can be more consistent.
Attachment #8503403 -
Flags: review+
Updated•10 years ago
|
Keywords: checkin-needed
Comment 9•10 years ago
|
||
Oops, landed with the wrong patch author. Fixed: https://hg.mozilla.org/integration/fx-team/rev/60b1791ae0cc https://hg.mozilla.org/integration/fx-team/rev/e23264b514a2 vivek, for future reference, you should make sure to export your patches with your username and a commit message :)
https://hg.mozilla.org/mozilla-central/rev/e23264b514a2
Status: NEW → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
Comment 11•9 years ago
|
||
Adding a page to reading list and going to the reading list panel, the item has a border divider. Verified fixed on: Devices: Alcatel One Touch(Android 4.1.2) Build: Firefox for Android 36.0a1 (2014-11-23)
Status: RESOLVED → VERIFIED
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•