919767 - SIPCC CallInfo objects don't get cleaned up until browser closes

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect)

Description

[Adam Roach [:abr]]

I haven't been able to track down where it was introduced, but recent logs (and logs for the past couple of months at least) show that the SIPCC call info objects are being kept alive by an errant reference until browser shutdown. This can be demonstrated by turning on signaling logs; running a call; waiting for the PC destructor to be invoked (look for the timecard to be generated); waiting any arbitrary amount of time (from zero to infinity); and then closing the browser.

When the browser closes, you'll see one of these messages for every PC that was ever created during that browser's run:

19:09:19     INFO -  2101870976[10011d910]: [main|def] ccapi_call.c:57: SIPCC-SIP_CC_PROV: CCAPI_Call_releaseCallInfo: ref=0x1278254e0: count=1

Beyond being a memory leak, this interferes with any inter-thread dispatches during call info cleanup, such as is required by Bug 842549.

Comment 1

[Adam Roach [:abr]]

Attachment: Clean up Call and CallInfo when finished

Comment 2

[Ethan Hugg [:ehugg]]

Comment on attachment 809441 [details] [diff] [review]
Clean up Call and CallInfo when finished

Review of attachment 809441 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me.

Comment 3

[Adam Roach [:abr]]

https://tbpl.mozilla.org/?tree=Try&rev=d941033c55f3

Comment 4

[Adam Roach [:abr]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2d0c10c47ac5

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2d0c10c47ac5