919831 - Can't debug new packaged app with custom origin

Status: RESOLVED FIXED

(DevTools Graveyard :: WebIDE, defect, P1)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: test-webapi-permissions.tgz

STR: 

1. Add the attached app to the App Manager
2. Connect to a device or simulator
3. Click "Debug"

ER:

You are supposed to get a toolbox connected to the app.

AR:

The app is installed on the device, but it does not start, and no toolbox is shown.  Eventually, the message "Unable to connect to app" appears.

However, it *is* possible to connect to the app if you disconnect, reconnect, go to Installed Apps (it doesn't update the list until you reconnect), and click "Debug" there.

Even after this reconnection dance, it is still not possible to debug from the projects page.  That button attempts to reinstall the app again.

Comment 1

[Alexandre Poirot [:ochameau]]

Ok, that's because of the custom app origin field in its manifest.
  "origin": "app://test.webapi.permissions.com",

As the app is a packaged app, we create a random uuid for it and use app://$(random-uuid)/manifest.webapp manifest URL... but the app is installed with the manifest URL following its manifest overriden origin. app://test.webapi.permissions.com/manifest.webapp.

So when we try to launch the app, it fails, and it also fails when we try to get its actors.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Fix support of packaged apps with custom origin r=paul

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/5fd6af0ff7f8

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5fd6af0ff7f8

Comment 5

[Paul Rouget [:paul]]

Comment on attachment 809869 [details] [diff] [review]
Fix support of packaged apps with custom origin r=paul

[Approval Request Comment]
Bug caused by (feature/regressing bug #): new feature (app manager)
User impact if declined: some app
Testing completed (on m-c, etc.): Some project can't be debugged
Risk to taking this patch (and alternatives if risky): low
String or IDL/UUID changes made by this patch: none

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/11994bee127d

Comment 7

[Mihai Morar, (:MihaiMorar)]

I am not able to open the attached app using Firefox OS 1.3 Simulator. The format of the app is not recognized by the app manager. Ryan can you please provide some STR about how this attached app can be opened?

Comment 8

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

You'll need to expand the .tgz file into a directory first.  On Linux or Mac, you could do that with the command "tar xzvf test-webapi-permissions.tgz".  Then, you should be able to point the App Manager at the expanded directory that you get from that.

Hopefully that helps!

Comment 9

[Catalin Varga [QA][:VarCat]]

Verified as fixed on FF 26.05
Build identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
Build id:20131114085019

Environments used:
Win 7 x64
Mac Os 10.7.5
Ubuntu 12.10 x32

Comment 10

[Manuela Muntean [Away]]

Verified as fixed with Firefox 27 beta 1 (build ID: 20131209204824) on: Win 7 64-bit, Ubuntu 12.04 32-bit and Mac OS X 10.7.5